camera/component information: URI zero termination #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way it's much easier to deal with this message as the last char can just be set to '\0' before handing it. Otherwise it needs to be copied first.
This way it's much easier to deal with this message as the last char can just be set to '\0' before handing it. Otherwise it needs to be copied first.
bkueng
approved these changes
Mar 1, 2022
|
@julianoes Would there be any implications to existing implementations? My thought was no, but want to make sure before I merge. |
|
Merging. As discussed in dev call, only implication is if a particular camera uses the whole URL, and that is unlikely. Otherwise better for all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way it's much easier to deal with these message as the last char can just be set to '\0' before handing it. Otherwise the string needs to be copied first.