common.xml: Prefer COMMAND_INT when command includes altitude field #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
reviewed
May 3, 2023
hamishwillee
reviewed
May 3, 2023
nexton-winjeel
force-pushed
the
upstream/clarify_command_frame
branch
from
e5e4af9
to
ad6ab79
Compare
|
@hamishwillee: Updated with your improvements. |
hamishwillee
approved these changes
May 3, 2023
There was a problem hiding this comment.
FYI @auturgy @julianoes
I am merging this as a "no brainer". Essentially it adds the fact that unless the frame of positional information is explicitly specified in a particular MAV_CMD fields, using COMMAND_LONG means that the frame is ambiguous.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1981, without a reference
MAV_FRAME(as is sent inCOMMAND_INT) it is possible for receiving systems to mis-interpret altitude values sent inMAV_CMDs. This PR updates the descriptions forCOMMAND_INTandCOMMAND_LONGto indicate thatCOMMAND_INTis preferred when the command includes an altitude field.