Add MAV_RESULT_COMMAND_UNSUPPORTED_MAV_FRAME #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed in dev call: https://github.com/mavlink/mavlink/wiki/20230607-Dev-Meeting |
marcinolokk
pushed a commit
to Auterion/mavlink
that referenced
this pull request
Jun 16, 2023
marcinolokk
pushed a commit
to Auterion/mavlink
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If MAV_CMD has a location where the frame is not explicitly specified this is taken from the
COMMAND_INT.framefield. There is no way to query what frames are supported for a particular command by a particular flight stack. Many flight stacks just ignore the frame, using whatever arbitrary frame they support.This adds a
MAV_RESULT_COMMAND_UNSUPPORTED_MAV_FRAMEto tell a user that the command may be valid, but not with the supported frame. If implemented a user could use this to determine what frames are supported.Note that if autopilots continue to do the very bad thing of silently just accepting any frame this will make no difference. But this is still "the right design" by any measure.