Clarify DO_REPOSITION vs NAV_WAYPOINT #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
Jun 8, 2023
hamishwillee
commented
Jun 8, 2023
hamishwillee
commented
Jun 8, 2023
There was a problem hiding this comment.
This was approved by dev call https://github.com/mavlink/mavlink/wiki/20230607-Dev-Meeting
marcinolokk
pushed a commit
to Auterion/mavlink
that referenced
this pull request
Jun 16, 2023
* Clarify DO_REPOSITION vs NAV_WAYPOINT * Apply suggestions from code review
marcinolokk
pushed a commit
to Auterion/mavlink
that referenced
this pull request
Jun 28, 2023
* Clarify DO_REPOSITION vs NAV_WAYPOINT * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waypoints are for missions, while do_reposition is for guided movement. You might in theory use either for both cases, but the fields are "optimized" for the particular use/would be ambiguous in the other use.