Add missionOnly="true" attribute to fence cases #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
approved these changes
Jun 8, 2023
|
You make a good point. Though missionProtocolOnly is messier. My bigger worry is that people will just choose to assume this means that everything not with this can be used in a mission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fence mav_cmds only be make sense in a mission. This tags them as such. I don't know if there are others.
FYI I did find some cases for "command only" - specifically the ones where you fetch information - unless we support dynamically configurable missions, having a command to get autopilot version or camera information not useful in a mission. Not sure if worth adding though.
Once this goes in I'll update docs to autogenerate a note for those cases.