Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved docs from XML generation_toolchain #2103

Merged
merged 2 commits into from
May 16, 2024

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Apr 18, 2024

The current docs generation toolchain uses XSL conversion of the XML to HTML, followed by some massaging of the produced HTML to produce some final output.

This is very clever and all, but inherently limited for generating docs, because:

  1. Files don't know about each other - we can't, for example, create a combined file, even if we want.
  2. The output is HTML. That should work in markdown, but rendering is spotty.

So what this does is copy the ideas behind mavgen parser (but using beautifulsoup) to parse the XML into Python, and then generate markdown output.

This replaces the top level files.
Includes workflow to build the files, and start of workflow to deploy files. However no point finishing that until the old version is disabled, which depends on CI that relies on Daniel Agar. Waiting

@hamishwillee hamishwillee force-pushed the improved_docs_generation_toolchain branch 2 times, most recently from 587f58a to 0be4689 Compare May 1, 2024 01:45
@hamishwillee hamishwillee force-pushed the improved_docs_generation_toolchain branch from 412d0a6 to 77fda2a Compare May 15, 2024 03:33
- Make replaced-by a link
- Fix message field desc
- Make enums in param values into links
- Fixes following testing
- Add deprecated desc, if exists
- Add todo if we ever get WIP tags with text in them
- Make the main lists to dicts, to allow easier merging
- Merge XMLs
- Fix up ordering of items
- Make more robust - can spot new fields
- Improve table layout
- Add max, min, invalid, instance, default, to fields
- Add highlighting for WIP/Deprecated
- Minor fix to intros
- Add placeholder for building dialect tree
- Add summary of stuff in THIS file
- Flake8 Lint
- Workflow to deploy docs + dependencies file
@hamishwillee hamishwillee force-pushed the improved_docs_generation_toolchain branch from dc19845 to 757df34 Compare May 15, 2024 04:57
@hamishwillee
Copy link
Collaborator Author

Self merging.

@hamishwillee hamishwillee merged commit 2b87f2e into master May 16, 2024
15 checks passed
@hamishwillee hamishwillee deleted the improved_docs_generation_toolchain branch May 16, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant