with this fix ,it will avoid eigen error on 32 bits system #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I search the problem in check log ,I think maybe the conflict comes from the test_mavros, I am confused. |
|
Don't worry about CI failures. Unfortunately Travis now are broken. ROS CI most time fails on libmavconn test. |
vooon
approved these changes
Nov 6, 2018
vooon
added a commit
that referenced
this pull request
Nov 6, 2018
vooon
added a commit
that referenced
this pull request
Nov 6, 2018
|
@vooon That's better~Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue and the solution I have reported here #1110 .
Here is the flexible way to avoid the eigen not perfectly aligned issue on 32 bits system.If you libeigen support SSE packet, you will need this fix on your board.
http://eigen.tuxfamily.org/dox-devel/group__TopicStructHavingEigenMembers.htmlhere explain why this fix is needed, and why it can also fit X86-X64system.
In addition,the version is pasted here :ROS distro is above Lunar ,and GCC is above 5.4 and libeigen3 is above 3.3.4-4