param plugin : add msg and publisher to catch latest param value #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kiwa21 can you please explain the rationale behind adding this? |
|
Goodrobots is developing a web GCS / web API. |
vooon
reviewed
Jan 2, 2019
| @@ -0,0 +1,7 @@ | |||
| # Parameter msg. | |||
|
|
|||
| string param_id | |||
There was a problem hiding this comment.
Here maybe better to add Header.
Just to carry receive stamp.
| param_msg.param_type = pmsg.param_type; | ||
| param_msg.param_count = pmsg.param_count; | ||
| param_msg.param_index = pmsg.param_index; | ||
| param_value_pub.publish(param_msg) |
There was a problem hiding this comment.
Where is filling of value? Indentation error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by the goodrobots projects by @fnoop : https://github.com/goodrobots
I'm open to all suggestions.
Thanks,