Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS2: rewrite param plugin to provide parameter interface directly #1579

Closed
vooon opened this issue May 28, 2021 · 1 comment
Closed

ROS2: rewrite param plugin to provide parameter interface directly #1579

vooon opened this issue May 28, 2021 · 1 comment
Assignees
@vooon
Labels
bug fix plugin ros2
Projects
ROS2 support
Milestone
Version 2.1

Comments

@vooon
Copy link
Member

vooon commented May 28, 2021

Current implementation that uses default parameter server implementation works badly, sometimes it gets deadlocks.
So as not to warrior with chicken-and-egg problem i would rather provide direct interface to parameters map.
@vooon vooon added this to the Version 2.1 milestone May 28, 2021
@vooon vooon added this to TODO in ROS2 support via automation May 28, 2021
vooon added a commit that referenced this issue Jun 20, 2021
@vooon
plugin: param: #1579: rewrite plugin to implement standard parameter …
d6345b8 
…services

Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
vooon added a commit that referenced this issue Jun 20, 2021
@vooon
plugin: param: #1579: implement std parameter events
1013fc0 
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
vooon added a commit that referenced this issue Jun 20, 2021
@vooon
plugin: param: #1579: fix cpplint warnings
f9dce35 
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
@vooon vooon moved this from TODO to In Progress in ROS2 support Jun 20, 2021
@vooon vooon moved this from In Progress to Testing in ROS2 support Jun 20, 2021
@vooon vooon self-assigned this Jun 20, 2021
@vooon
Copy link
Member Author

vooon commented Jun 20, 2021

Done.

@vooon vooon closed this as completed Jun 20, 2021
ROS2 support automation moved this from Testing to Done Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vooon vooon

Labels
bug fix plugin ros2
Projects
ROS2 support
  
Done
Milestone
Version 2.1
Development

No branches or pull requests
1 participant
@vooon