Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MANUAL_CONTROL handling with new plugin #378

Merged
merged 2 commits into from
Aug 28, 2015
Merged

Add MANUAL_CONTROL handling with new plugin #378

merged 2 commits into from
Aug 28, 2015

Conversation

protobits
Copy link

Cleaned up pull request #377 (I messed up my repo in the process of fixing).

mavlink_msg_manual_control_decode(msg, &manual_control);

mavros_msgs::ManualControl manual_control_ros;
manual_control_ros.header.stamp = ros::Time::now(); // correct?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, correct because message don't have any timestamp.

@vooon
Copy link
Member

vooon commented Aug 28, 2015

Ok, now it looks good to merge. But maybe you implement send code too?

@protobits
Copy link
Author

I'm not aware that this mavlink message goes both ways. I think it is only
sent by the autopilot, and not received. But I'm not sure.

On Fri, Aug 28, 2015 at 6:12 PM, Vladimir Ermakov notifications@github.com
wrote:

Ok, now it looks good to merge. But maybe you implement send code too?


Reply to this email directly or view it on GitHub
#378 (comment).

@vooon
Copy link
Member

vooon commented Aug 28, 2015

You may check QGC code. In SITL/HIL mode it has ability to send joystick data. I think via that message.

@protobits
Copy link
Author

To be honest, at the moment I'm not sure If I can manage time to look into
that. I can do it bit further on and provide a separate pull request.

On Fri, Aug 28, 2015 at 7:38 PM, Vladimir Ermakov notifications@github.com
wrote:

You may check QGC code. In SITL/HIL mode it has ability to send joystick
data. I think via that message.


Reply to this email directly or view it on GitHub
#378 (comment).

@vooon
Copy link
Member

vooon commented Aug 28, 2015

Ok.

vooon added a commit that referenced this pull request Aug 28, 2015
Add MANUAL_CONTROL handling with new plugin
@vooon vooon merged commit 2fb5a82 into mavlink:master Aug 28, 2015
@protobits
Copy link
Author

@vooon I'm just testing this using running mavros on my odroid connected to the pixhawk via the TELEM port and I can't see the MANUAL_CONTROL stream there. However, if I connect to the pixhawk from my laptop using USB cable, I do see the stream. Do you know what could be the cause?

@vooon
Copy link
Member

vooon commented Aug 31, 2015

I think stream rate not configured on TELEM. See rc.usb file.

@vooon
Copy link
Member

vooon commented Aug 31, 2015

Hmm, now stream config for usb is moved to mavlink app, but you still can configure streams via extras.txt

@protobits
Copy link
Author

Ok, thanks!

On Mon, Aug 31, 2015 at 12:24 PM, Vladimir Ermakov <notifications@github.com

wrote:

I think stream rate not configured on TELEM. See rc.usb
https://github.com/PX4/Firmware/blob/9365c5a4383d8702e66b5f0e3f95a1acb3fd5cac/ROMFS/px4fmu_common/init.d/rc.usb
file.


Reply to this email directly or view it on GitHub
#378 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants