Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mavlink 2.0 support (WIP) #554

Merged
merged 95 commits into from
Jun 22, 2016
Merged

Mavlink 2.0 support (WIP) #554

merged 95 commits into from
Jun 22, 2016

Conversation

vooon
Copy link
Member

@vooon vooon commented Jun 6, 2016 •
edited
Loading

This is WIP PR for Mavlink 2.0 support.

Fixes #543 (#553), #522, #286.

@vooon vooon added this to the Version 0.18 milestone Jun 6, 2016
@vooon
Copy link
Member Author

vooon commented Jun 8, 2016

I decided to make C++ MAVLink library: mavlink/mavlink#568

@vooon
Copy link
Member Author

vooon commented Jun 9, 2016

I found bug with memory leak. Test - simple echo server (test_hang.cpp).
It appears only when send_message() was called from that object IO thread, for example message_received slot send something back.

Also that bug exists in current master too.

@vooon
Copy link
Member Author

vooon commented Jun 14, 2016

All plugins ported. One more thing i do not like - static functions of UAS.

TODO: fix tests, protocol version selection param.

@vooon
Copy link
Member Author

vooon commented Jun 14, 2016

Finally! It works!

But not fully tested and require PR mavlink/mavlink#568

@vooon vooon mentioned this pull request Jun 22, 2016
Merged
@vooon
Copy link
Member Author

vooon commented Jun 22, 2016

Last two things for this PR is UAS::sig_connection_changed and idea to move message handlers out of FCU io-thread.

But i decided not to use ROS interprocess pub-sub, so lets try as is.

@vooon vooon merged commit f90bdcd into master Jun 22, 2016
@vooon vooon mentioned this pull request Jun 22, 2016
Closed
@vooon vooon deleted the pr-mavlink2 branch June 22, 2016 21:37
@ChrisTimperley ChrisTimperley mentioned this pull request Mar 13, 2020
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API change enhancement
Projects
None yet
Milestone
Version 0.18
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vooon @scott-eddy