Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setpoint_velocity to simple twist for compatibility with ROS n… #655

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

khancyr
Copy link
Contributor

@khancyr khancyr commented Feb 14, 2017

…av stack

Current setpoint_velocity require twistStamped but all ROS navigation stack and what is ising move_base is using simple Twist (http://wiki.ros.org/move_base?distro=kinetic ). Using simple twist will allow direct mapping from navigation to setpoint_velocity and use ROS controllers

@vooon
Copy link
Member

vooon commented Feb 14, 2017

I'm not sure that i want to break ROS API. Maybe better add additional subscriber?

@khancyr
Copy link
Contributor Author

khancyr commented Feb 14, 2017

@vooon Ok I will rework that tomorrow to just add the twist listener . I submit this before talking to you because I didn't find an example in ROS using cmd_vel with twistStamped, But if it was done like that before, just adding a subcriber will preserve current compatibiliy and add more on ROS side!

@vooon
Copy link
Member

vooon commented Feb 15, 2017

Old version of plugins has subscriber type switch parameter, but i removed it because of error prone.

@khancyr
Copy link
Contributor Author

khancyr commented Mar 20, 2017

@vooon ok, rebase and twist listener added. It is working as intend with ROS nav stack see https://www.youtube.com/watch?v=kYMzVeW-0-E&index=5&list=PL6sCNLbHuYxaLtItzADD5zHxixUtQPSvk as example (I know slam is failing but vel order are well send !)

@vooon vooon merged commit 06665d2 into mavlink:master Mar 20, 2017
@vooon vooon added this to the Version 0.19 milestone Mar 20, 2017
@vooon
Copy link
Member

vooon commented Mar 20, 2017

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants