Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #36 - Added Jumu'a sensors #40

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Issue #36 - Added Jumu'a sensors #40

merged 7 commits into from
Oct 12, 2023

Conversation

moha-tah
Copy link
Collaborator

Issue #36 :

C'est ma première pull request, j'aimerais bien avoir ton avis sur ce code pour le commit sur le master car je suis pas très confiant et c'est possible que j'ai oublié quelque chose.

Exemple dans l'affichage UI :

Image d'exemple du sensor jumu'a sur HA

Affichage dans les settings :

Capture d’écran 2023-07-21 à 03 42 09

@moha-tah moha-tah added the enhancement New feature or request label Jul 21, 2023
@moha-tah moha-tah self-assigned this Jul 21, 2023
@moha-tah moha-tah marked this pull request as draft September 14, 2023 17:25
@moha-tah moha-tah changed the title Issue #36 - Added Jumu'a (and Eid) Sensors Issue #36 - Added Jumu'a sensors Sep 14, 2023
@ibrahim-zehhaf-mawaqit ibrahim-zehhaf-mawaqit linked an issue Sep 15, 2023 that may be closed by this pull request
Add Jumu'a sensor for H-A #36
Closed
@ibrahim-zehhaf-mawaqit
Copy link
Contributor

Très bon début @mohaThr félicitation
Alors je ne suis pas le mieux placer pour review ta pr je ne suis pas un spécialiste de python mais j'essaie
2 petites remarques

  • Merci d'utiliser l'anglais pour les échanges afin de faciliter la discussion avec des anglophones
  • Penses à lier a PR à l'issue pour un meilleur suivi et le fonctionnement de l’automatisation github

@moha-tah moha-tah marked this pull request as ready for review September 20, 2023 20:59
@moha-tah moha-tah linked an issue Sep 20, 2023 that may be closed by this pull request
Enhance login error handling #35
Closed
@moha-tah moha-tah removed a link to an issue Sep 20, 2023
Enhance login error handling #35
Closed
@ibrahim-zehhaf-mawaqit
Copy link
Contributor

It's ok now, installed and it works, I will test it for a few days before publishing insh'Allah

@ibrahim-zehhaf-mawaqit ibrahim-zehhaf-mawaqit merged commit d1920c2 into master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahim-zehhaf-mawaqit ibrahim-zehhaf-mawaqit ibrahim-zehhaf-mawaqit approved these changes

Assignees

@moha-tah moha-tah

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Jumu'a sensor for H-A
2 participants
@moha-tah @ibrahim-zehhaf-mawaqit