Skip to content

Commit

Permalink
Reset SIGHUP handler on NCursesUI destruction
Browse files Browse the repository at this point in the history
SIGHUP handler could trigger crashes if the EventManager was
already destructed when it was triggered.

Fixes #3288
  • Loading branch information
mawww committed Jan 11, 2020
1 parent fe80502 commit b85365b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/ncurses_ui.cc
Expand Up @@ -364,7 +364,7 @@ NCursesUI::~NCursesUI()
endwin();
tcsetattr(STDIN_FILENO, TCSAFLUSH, &m_original_termios);
set_signal_handler(SIGWINCH, SIG_DFL);
set_signal_handler(SIGCONT, SIG_DFL);
set_signal_handler(SIGHUP, SIG_DFL);
set_signal_handler(SIGTSTP, SIG_DFL);
}

Expand Down Expand Up @@ -567,7 +567,7 @@ Optional<Key> NCursesUI::get_next_key()
if (sighup_raised)
{
set_signal_handler(SIGWINCH, SIG_DFL);
set_signal_handler(SIGCONT, SIG_DFL);
set_signal_handler(SIGHUP, SIG_DFL);
if (m_window)
m_window.destroy();
m_stdin_watcher.disable();
Expand Down

0 comments on commit b85365b

Please sign in to comment.