move composed editing commands to edit.kak #8

alexherbo2 · 2014-01-02T23:05:59Z

def wq   %{ write    ; quit  }
def wq!  %{ write!   ; quit! }
def waq  %{ writeall ; quit  }
def waq! %{ writeall!; quit! }

The text was updated successfully, but these errors were encountered:

mawww · 2014-03-26T09:23:18Z

Nope, i think these shortcuts should stay available in all Kak configs, so should not depend on if edit.kak is sourced.

My terminal's workspace is configured to be displayed on an external monitor if connected. When I connect my external monitor, the workspace switches to that monitor and Kakoune segfaults consistently. The crash happens in "TerminalUI::Screen::output" where we access a dangling reference auto output_line = [&](const Line& line) { ColumnCount pending_move = 0; for (auto& [text, skip, face] : line.atoms) { /-> if (text.empty() and skip == 0) | continue; | cannot access memory referenced by "text" The stack trace is Program received signal SIGSEGV, Segmentation fault. 0x0000555555a5f1ac in Kakoune::String::Data::is_long (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:180 (gdb) bt #0 0x0000555555a5f1ac in Kakoune::String::Data::is_long (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:180 mawww#1 0x0000555555a5f1d6 in Kakoune::String::Data::size (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:181 mawww#2 0x0000555555de34e4 in Kakoune::String::length (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:139 mawww#3 Kakoune::StringOps<Kakoune::String, char>::empty (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:68 mawww#4 operator() (__closure=0x7fffffffba50, line=...) at terminal_ui.cc:303 mawww#5 0x0000555555de45aa in Kakoune::TerminalUI::Screen::output (this=0x5555560a7a60, force=true, synchronized=true, writer=...) at terminal_ui.cc:371 mawww#6 0x0000555555de548a in Kakoune::TerminalUI::redraw (this=0x5555560a7a40, force=true) at terminal_ui.cc:535 mawww#7 0x0000555555de579e in Kakoune::TerminalUI::refresh (this=0x5555560a7a40, force=true) at terminal_ui.cc:556 mawww#8 0x0000555555a9ae71 in Kakoune::Client::redraw_ifn (this=0x55555609f9b0) at client.cc:284 mawww#9 0x0000555555aab3db in Kakoune::ClientManager::redraw_clients (this=0x7fffffffd060) at client_manager.cc:233 mawww#10 0x0000555555c86ef8 in Kakoune::run_server (session="", server_init="", client_init="", init_buffer="fish-rust/src/ast.rs", init_coord=..., flags=Kakoune::ServerFlags::None, ui_type=Kakoune::UIType::Terminal, debug_flags=Kakoune::DebugFlags::None, files=ArrayView<Kakoune::StringView> = {...}) at main.cc:908 mawww#11 0x0000555555c8bb76 in main (argc=2, argv=0x7fffffffe7b8) at main.cc:1263 We check for terminal resize in TerminalUI::TerminalUI TerminalUI::get_next_key TerminalUI::draw TerminalUI::suspend I think neither of those happens when the window is moved. Looks like TerminalUI::refresh relies on up-to-date dimensions, so add a resize check here too, fixing the crash.

When Kakoune's terminal is shown my laptop monitor and I plug in my external monitor, the terminal's workspace will move to that external monitor. When this happens, Kakoune segfaults consistently. The crash happens in "TerminalUI::Screen::output" where we access a dangling reference auto output_line = [&](const Line& line) { ColumnCount pending_move = 0; for (auto& [text, skip, face] : line.atoms) { /-> if (text.empty() and skip == 0) | continue; | cannot access memory referenced by "text" The stack trace is Program received signal SIGSEGV, Segmentation fault. 0x0000555555a5f1ac in Kakoune::String::Data::is_long (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:180 (gdb) bt #0 0x0000555555a5f1ac in Kakoune::String::Data::is_long (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:180 mawww#1 0x0000555555a5f1d6 in Kakoune::String::Data::size (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:181 mawww#2 0x0000555555de34e4 in Kakoune::String::length (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:139 mawww#3 Kakoune::StringOps<Kakoune::String, char>::empty (this=0x1a) at /home/johannes/git/kakoune/src/string.hh:68 mawww#4 operator() (__closure=0x7fffffffba50, line=...) at terminal_ui.cc:303 mawww#5 0x0000555555de45aa in Kakoune::TerminalUI::Screen::output (this=0x5555560a7a60, force=true, synchronized=true, writer=...) at terminal_ui.cc:371 mawww#6 0x0000555555de548a in Kakoune::TerminalUI::redraw (this=0x5555560a7a40, force=true) at terminal_ui.cc:535 mawww#7 0x0000555555de579e in Kakoune::TerminalUI::refresh (this=0x5555560a7a40, force=true) at terminal_ui.cc:556 mawww#8 0x0000555555a9ae71 in Kakoune::Client::redraw_ifn (this=0x55555609f9b0) at client.cc:284 mawww#9 0x0000555555aab3db in Kakoune::ClientManager::redraw_clients (this=0x7fffffffd060) at client_manager.cc:233 mawww#10 0x0000555555c86ef8 in Kakoune::run_server (session="", server_init="", client_init="", init_buffer="fish-rust/src/ast.rs", init_coord=..., flags=Kakoune::ServerFlags::None, ui_type=Kakoune::UIType::Terminal, debug_flags=Kakoune::DebugFlags::None, files=ArrayView<Kakoune::StringView> = {...}) at main.cc:908 mawww#11 0x0000555555c8bb76 in main (argc=2, argv=0x7fffffffe7b8) at main.cc:1263 We check for terminal resize in TerminalUI::TerminalUI TerminalUI::get_next_key TerminalUI::draw TerminalUI::suspend I think neither of those happens when the window is moved. Looks like TerminalUI::refresh relies on up-to-date dimensions, so add a resize check here too, fixing the crash.

When Kakoune's terminal is shown on my laptop monitor and I plug in my external monitor, the terminal's workspace will move to that external monitor. When this happens, Kakoune may segfault. There are multiple resize events (SIGWINCH) in quick succession; it crashes because we handle SIGWINCH during rendering. The problem happens during execution of "TerminalUI::Screen::output" (frame mawww#18). When we receive SIGWINCH while writing to stdout, write(2) fails with EAGAIN, prompting us to handle pending events (See ae001a1 (Run EventManager whenever writing to a file descriptor would block, 2022-05-10)). We update the screen size in check_resize() here: mawww#4 Kakoune::TerminalUI::check_resize (force=<optimized out>) at terminal_ui.cc:683 mawww#5 Kakoune::TerminalUI::get_next_key () at terminal_ui.cc:719 mawww#6 operator() (__closure=0x555555984198) at terminal_ui.cc:484 mawww#7 std::__invoke_impl<void, Kakoune::TerminalUI::TerminalUI()::<lambda(Kakoune::FDWatcher&, Kakoune::FdEvents, Kakoune::EventMode)>&, Kakoune::FDWatcher&, Kakoune::FdEvents, Kakoune::EventMode> (__f=...) at /usr/include/c++/12.2.1/bits/invoke.h:61 mawww#8 std::__invoke_r<void, Kakoune::TerminalUI::TerminalUI()::<lambda(Kakoune::FDWatcher&, Kakoune::FdEvents, Kakoune::EventMode)>&, Kakoune::FDWatcher&, Kakoune::FdEvents, Kakoune::EventMode> (__fn=...) at /usr/include/c++/12.2.1/bits/invoke.h:111 mawww#9 std::_Function_handler<void(Kakoune::FDWatcher&, Kakoune::FdEvents, Kakoune::EventMode), Kakoune::TerminalUI::TerminalUI()::<lambda(Kakoune::FDWatcher&, Kakoune::FdEvents, Kakoune::EventMode)> >::_M_invoke(const std::_Any_data &, Kakoune::FDWatcher &, Kakoune::FdEvents &&, Kakoune::EventMode &&) (__functor=..., __args#0=..., __args#1=<optimized out>, __args#2=<optimized out>) at /usr/include/c++/12.2.1/bits/std_function.h:290 mawww#10 std::function<void (Kakoune::FDWatcher&, Kakoune::FdEvents, Kakoune::EventMode)>::operator()(Kakoune::FDWatcher&, Kakoune::FdEvents, Kakoune::EventMode) const (__args#2=<optimized out>, __args#1=<optimized out>, __args#0=...) at /usr/include/c++/12.2.1/bits/std_function.h:591 mawww#11 Kakoune::FDWatcher::run (mode=Kakoune::EventMode::Urgent, events=<optimized out>) at event_manager.cc:28 mawww#12 Kakoune::EventManager::handle_next_events (mode=mode@entry=Kakoune::EventMode::Urgent, sigmask=sigmask@entry=0x0, block=<optimized out>, block@entry=false) at event_manager.cc:143 mawww#13 Kakoune::write (fd=1, data=...) at file.cc:273 mawww#14 Kakoune::BufferedWriter<4096>::flush () at string.hh:236 mawww#15 Kakoune::BufferedWriter<4096>::write (data="t file.hh:145 mawww#16 Kakoune::TerminalUI::Screen::set_face (face=..., writer=...) at terminal_ui.cc:255 mawww#17 operator() (line=..., __closure=<synthetic pointer>) at terminal_ui.cc:326 mawww#18 Kakoune::TerminalUI::Screen::output (force=force@entry=true, synchronized=<optimized out>, writer=...) at terminal_ui.cc:402 mawww#19 Kakoune::TerminalUI::redraw (force=force@entry=true) at terminal_ui.cc:571 mawww#20 Kakoune::TerminalUI::refresh (force=<optimized out>) at terminal_ui.cc:592 mawww#21 Kakoune::Client::redraw_ifn () at client.cc:282 mawww#22 Kakoune::ClientManager::redraw_clients () at client_manager.cc:232 mawww#23 Kakoune::run_server (session=..., server_init=..., client_init=..., init_buffer="fish-rust/src/ast.rs", init_coord=..., flags=Kakoune::ServerFlags::None, ui_type=Kakoune::UIType::Terminal, debug_flags=<optimized out>, files=ArrayView<Kakoune::StringView> = {...}) at main.cc:893 mawww#24 main (argc=<optimized out>, argv=<optimized out>) at main.cc:1243 Thereafter, "TerminalUI::Screen::output" resumes and crashes due to a buffer overflow in "lines" which has been resized.

ghost assigned mawww Jan 3, 2014

mawww closed this as completed Mar 26, 2014

DISSISOR mentioned this issue Apr 26, 2024

[BUG][CRASH] ctags-search crashes kakoune after trying to browse autocomplete options. #5157

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move composed editing commands to edit.kak #8

move composed editing commands to edit.kak #8

alexherbo2 commented Jan 2, 2014

mawww commented Mar 26, 2014

move composed editing commands to edit.kak #8

move composed editing commands to edit.kak #8

Comments

alexherbo2 commented Jan 2, 2014

mawww commented Mar 26, 2014