Make Color::validate_alpha() a constexpr function. #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We call it from a constexpr constructor, so it needs to be constexpr itself. Fixes mawww#4544.
mujo-hash
added a commit
to mujo-hash/gentoo
that referenced
this pull request
May 18, 2022
Fixes bug 840647 Patch taken from upstream and will no longer be needed once there is a new release. See mawww/kakoune#4544 and mawww/kakoune#4549 for additional details.
mujo-hash
added a commit
to mujo-hash/gentoo
that referenced
this pull request
May 18, 2022
Patch taken from upstream and will no longer be needed once there is a new release. See mawww/kakoune#4544 and mawww/kakoune#4549 for additional details. Signed-off-by: Ian Hixson <mujo@sdf.org>
mujo-hash
added a commit
to mujo-hash/gentoo
that referenced
this pull request
May 18, 2022
Fix build with gcc-12.1.0 bug #840647 Patch taken from upstream and will no longer be needed once there is a new release. See mawww/kakoune#4544 and mawww/kakoune#4549 for additional details. Closes: https://bugs.gentoo.org/840647 Signed-off-by: Ian Hixson <mujo@sdf.org>
mujo-hash
added a commit
to mujo-hash/gentoo
that referenced
this pull request
May 18, 2022
Fix build with gcc-12.1.0 bug #840647 Patch taken from upstream and will no longer be needed once there is a new release. See mawww/kakoune#4544 and mawww/kakoune#4549 for additional details. Closes: https://bugs.gentoo.org/840647 Signed-off-by: Ian Hixson <mujo@sdf.org>
mujo-hash
added a commit
to mujo-hash/gentoo
that referenced
this pull request
May 18, 2022
Fix build with gcc-12.1.0 bug #840647 Patch taken from upstream and will no longer be needed once there is a new release. See mawww/kakoune#4544 and mawww/kakoune#4549 for additional details. Closes: https://bugs.gentoo.org/840647 Signed-off-by: Ian Hixson <mujo@sdf.org>
mujo-hash
added a commit
to mujo-hash/gentoo
that referenced
this pull request
May 18, 2022
Fix build with gcc-12.1.0 bug #840647 Patch taken from upstream and will no longer be needed once there is a new release. See mawww/kakoune#4544 and mawww/kakoune#4549 for additional details. Closes: https://bugs.gentoo.org/840647 Signed-off-by: Ian Hixson <mujo@sdf.org>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 19, 2022
Fix build with gcc-12.1.0 bug #840647 Patch taken from upstream and will no longer be needed once there is a new release. See mawww/kakoune#4544 and mawww/kakoune#4549 for additional details. Closes: https://bugs.gentoo.org/840647 Signed-off-by: Ian Hixson <mujo@sdf.org> Closes: #25551 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call it from a constexpr constructor, so it needs to be constexpr itself.
Fixes #4544.