Add normal commands to extend selections downwards/upwards. #4929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrufat
force-pushed
the
add-expand-lines-upwards-downwards
branch
2 times, most recently
from
d5a73fe
to
d9bd153
Compare
Since we dropped the we changed the `x` keys behaviors, the `X` and `<a-X>` have been free. I think it makes sense to make them work mostly like the `/` command, where shift extends the selection and alt changes the direction. So the implemented behavior is be: <X> : select the current and next line (extend downwards) <a-X> : select the current and previous line (extend upwards)
arrufat
force-pushed
the
add-expand-lines-upwards-downwards
branch
from
d9bd153
to
b11e895
Compare
|
I am not too keen on that change, free keys are very scarce and kakoune normal mode is already quite complex, I am not convinced adding a slightly different way of doing |
|
Ok, got it. Just wanted to make sure this was considered. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we changed the
xkeys behaviors, theXand<a-X>have been free.I think it makes sense to make them work mostly like
/and other commands, where shift extends the selection and alt changes the direction.So, the implemented behavior is:
<X>: select the current and next line (extend downwards)<a-X>: select the current and previous line (extend upwards)Overall, I think it's a good change that's consistent with the way other keys (and modifiers) behave in Kakoune.
Note: in this implementation, pressing once
<X>or<a-X>will result in two lines being selected (regardless of the current line being completely selected). This makes the keys more predictable, but it might be surprising at the beginning, if someone expects the oldXbehavior.