fix: correctly compute the style when setting undefined/none #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues Previously, when the value of a property was defined as `undefined`, it was also defined as `undefined` in the calculated style. This was a change from the mxGraph implementation and was not consistent with the style without the same property. This has now been corrected: when a value is defined as undefined, the value calculated is that of the default style or a "base" style. To match mxGraph's behavior, the same logic applies when the value is set to "none".
tbouffard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the value of a property was defined as
undefined, it was also defined asundefinedin the calculated style. This was a change from the mxGraph implementation and was not consistent with the style without the same property.This has now been corrected: when a value is set to
undefined, the value calculated is that of the default style or a "base" style.To match
mxGraph's behavior, the same logic applies when the value is set to "none".Notes
Original mxGraph's behavior: