Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Reference phpunit.xsd in phpunit.xml #47

Merged
merged 2 commits into from
Apr 18, 2018

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Apr 18, 2018

This PR

  • references phpunit.xsd (as installed with composer) in phpunit.xml
  • removes an unsupported configuration option

backupStaticAttributes="false"
bootstrap="vendor/autoload.php"
colors="true"
convertErrorsToExceptions="true"
convertNoticesToExceptions="true"
convertWarningsToExceptions="true"
processIsolation="false"
stopOnFailure="false"
syntaxCheck="false">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this was replaced by (if any), let me take a quick look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find it anywhere, must have been in a really old version.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @localheinz! I guess we can remove it. Thanks for your PR!

@maxbanton maxbanton merged commit c2e5e3b into maxbanton:master Apr 18, 2018
@localheinz localheinz deleted the feature/schema branch April 18, 2018 06:15
@localheinz
Copy link
Contributor Author

Thank you, @maxbanton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants