Added convenience methods for display directives #6
Conversation
|
Hi, Cheers, |
|
|
||
| /** | ||
| * @param string|null $contentDescription | ||
| * @param null|ImageSource|ImageSource[] $imageSource |
There was a problem hiding this comment.
This should be @param ImageSource[] $imageSource because a param should be array oder Object[|null] but not both.
| { | ||
| $image = new self(); | ||
|
|
||
| $image->contentDescription = $contentDescription; |
There was a problem hiding this comment.
CodeStyle $image->contentDescription = $contentDescription;
|
|
||
| $image->contentDescription = $contentDescription; | ||
|
|
||
| if (!is_null($imageSource)) |
There was a problem hiding this comment.
This logic will change to $image->sources[] = $sources; and CodeStyle is
if (is_array($imageSource)) {
$image->sources = $imageSource;
}| $imageSource->url = $url; | ||
| $imageSource->size = $size; | ||
| $imageSource->widthPixels = $widthPixels; | ||
| $imageSource->heightPixels = $heightPixels; |
There was a problem hiding this comment.
Aline with only one blank in this line
|
|
||
| $listItem->token = $token; | ||
| $listItem->image = $image; | ||
| $listItem->textContent = $textContent; |
| */ | ||
| public static function create($text, $type = self::TYPE_PLAIN_TEXT): Text | ||
| { | ||
| $text_ = new self(); |
There was a problem hiding this comment.
I don't like the underscore naming, perhaps $text = new self(); here and public static function create($value = null, $type = self::TYPE_PLAIN_TEXT): Text
| $text_ = new self(); | ||
|
|
||
| $text_->text = $text; | ||
| $text_->type = $type; |
There was a problem hiding this comment.
Here also aline equal signs with only one blank (in the longest line).
| $textContent = new self(); | ||
|
|
||
| $textContent->primaryText = $primaryText; | ||
| $textContent->secondaryText = $secondaryText; |
| use \MaxBeckers\AmazonAlexa\Response\Directives\Display\Image; | ||
| use \MaxBeckers\AmazonAlexa\Response\Directives\Display\Template; | ||
| use \MaxBeckers\AmazonAlexa\Response\Directives\Display\ListItem; | ||
| /** |
There was a problem hiding this comment.
one empty line after use statements
|
Hi Max, |
Hi,
I've added some convenience methods for the creation of display directives. Tests included.
Cheers,
Fabian