Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create() Methods for VideoApp #9

Merged
merged 4 commits into from
Dec 4, 2017
Merged

Conversation

fabeat
Copy link
Contributor

@fabeat fabeat commented Dec 1, 2017

I have also added a jsonSerialize() method to ResponseBody:
Amazon throws an error if the shouldEndSession flag is set:

shouldEndSession flag is not allowed with LaunchVideoApp.Launch Directive

use \MaxBeckers\AmazonAlexa\Response\OutputSpeech;
use \MaxBeckers\AmazonAlexa\Response\Directives\Display\RenderTemplateDirective;
use \MaxBeckers\AmazonAlexa\Response\Reprompt;
/**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing empty line ;)

@@ -31,4 +31,20 @@ public static function fromAmazonRequest(array $amazonRequest): Metadata

return $metadata;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one blank line

@fabeat
Copy link
Contributor Author

fabeat commented Dec 4, 2017

Done. Anything else? :)

@maxbeckers maxbeckers merged commit aa3ea66 into maxbeckers:master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants