trigger on update whenever a component is updated (#917)

maxence-charriere · Jan 15, 2024 · 200b16d · 200b16d
1 parent 8256c2c
commit 200b16d
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/pkg/app/node.go b/pkg/app/node.go
@@ -537,9 +537,9 @@ func (m nodeManager) updateComponent(ctx Context, v, new Composer) (UI, error) {
 		return v, nil
 	}
 
-	if updater, ok := v.(Updater); ok {
-		updater.OnUpdate(ctx)
-	}
+	// if updater, ok := v.(Updater); ok {
+	// 	updater.OnUpdate(ctx)
+	// }
 
 	ctx.removeComponentUpdate(v)
 	return m.UpdateComponentRoot(ctx, v)
@@ -549,6 +549,10 @@ func (m nodeManager) updateComponent(ctx Context, v, new Composer) (UI, error) {
 func (m nodeManager) UpdateComponentRoot(ctx Context, v Composer) (UI, error) {
 	ctx = m.context(ctx, v)
 
+	if updater, ok := v.(Updater); ok {
+		updater.OnUpdate(ctx)
+	}
+
 	root := v.root()
 	newRoot, err := m.renderComponent(v)
 	if err != nil {