Detect xcode git shim and handle appropriately #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxfierke
force-pushed
the
mf-detect_xcode_git_shim
branch
2 times, most recently
from
2ea8cff
to
d647a60
Compare
We need to ignore the default CLT shim for git and find the _real_ path ourselves to properly skip git fetches before git is available. Otherwise, it _seems_ present, but is actually missing and will pop up the Xcode CLT installer dialog and fail to fetch git resources
Static libs are missing for OpenSSL@3 in current GitHub Actions macOS-14 runner image is broken until it pulls in Homebrew/homebrew-core#169721 Removed "install from API" config too, since auto upgrades are disabled anyway.
maxfierke
force-pushed
the
mf-detect_xcode_git_shim
branch
from
d647a60
to
7c48a3f
Compare
Git lookup occurs before lsb_release might be available for distro determination, leading to a quick crash from an UnsupportedDistroError. Until we have a better way of doing distro detection, we'll need to avoid doing anything distro-specific until we know lsb_release is available
maxfierke
force-pushed
the
mf-detect_xcode_git_shim
branch
from
4d32475
to
949d3c2
Compare
xcrun is also a shim, and because we're optimizing for strap.sh & Homebrew, they'll install Xcode CLT anyway. Therefore, there's little value here in trying to be extra robust by using xcrun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ignore the default CLT shim for git and find the real path ourselves to properly skip git fetches before git is available. Otherwise, it seems present, but is actually missing and will pop up the Xcode CLT installer dialog and fail to fetch git resources.
This is based broadly on what is being done by Homebrew here: https://github.com/Homebrew/install/blob/52237ea74f41d2456a5b1bd3e4c2b0cb94485c3c/install#L118-L151