Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect xcode git shim and handle appropriately #57

Merged
merged 5 commits into from
May 9, 2024

Commits on Apr 28, 2024

  1. Handle missing git on macOS properly

    We need to ignore the default CLT shim for git and find the _real_ path ourselves to properly skip git fetches before git is available. Otherwise, it _seems_ present, but is actually missing and will pop up the Xcode CLT installer dialog and fail to fetch git resources
    maxfierke committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    91a45c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42d2b50 View commit details
    Browse the repository at this point in the history
  3. ci: force openssl@3 formula reinstall

    Static libs are missing for OpenSSL@3 in current GitHub Actions macOS-14 runner
    image is broken until it pulls in Homebrew/homebrew-core#169721
    
    Removed "install from API" config too, since auto upgrades are disabled anyway.
    maxfierke committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    7c48a3f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. linux: Avoid using distro platform abstraction for git lookup

    Git lookup occurs before lsb_release might be available for distro
    determination, leading to a quick crash from an UnsupportedDistroError.
    
    Until we have a better way of doing distro detection, we'll need to avoid
    doing anything distro-specific until we know lsb_release is available
    maxfierke committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    949d3c2 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Remove xcrun lookup of git

    xcrun is also a shim, and because we're optimizing for strap.sh & Homebrew, they'll install Xcode CLT anyway. Therefore, there's little value here in trying to be extra robust by using xcrun
    maxfierke committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4d31b5f View commit details
    Browse the repository at this point in the history