mesa: failed with llvm@6

[Gwang-Jin]

I changed llvm@6 into llvm@4.
--enable-gallium-llvm option was deprecated and needed to be changed to --enable-llvm.

Contributing to homebrew-xorg:

You can erase any parts of this template not applicable to your Pull Request.

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you included a log of the failed build without your patch using brew gist-logs <formula>?
• Does your submission pass
  brew audit --strict <formula> (where <formula> is the name of the formula you're submitting)?
• Have you built your formula locally prior to submission with brew install <formula>?

[dpo]

CircleCI says

checking for x11 xext xdamage >= 1.1 xfixes x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8... no
configure: error: Package requirements (x11 xext xdamage >= 1.1 xfixes x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8) were not met:

Package 'kbproto', required by 'x11', not found

[nir-krakauer]

These modifications to mesa.rb enable me to install it, on Ubuntu.

[Gwang-Jin]

@dpo I've added depends_on "linuxbrew/xorg/kbproto". And should I include xextproto and xf86vidmodeproto?

[dpo]

Here's the next error message:

checking for x11 xext xdamage >= 1.1 xfixes x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8... no
configure: error: Package requirements (x11 xext xdamage >= 1.1 xfixes x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8) were not met:

Package 'xextproto', required by 'xext', not found

Looks like we're discovering them one by one.

[maxim-belkin]

Hey, @Gwang-Jin and @dpo. Our planned course of action is to remove llvm dependency and make it an optional one. I'll look into mesa issues today

[Gwang-Jin]

@dpo I added other dependencies.

[Gwang-Jin]

@maxim-belkin Ok. It seems to be possible if we use
--with-dri-drivers= --with-gallium-drivers=r600 --disable-gallium-llvm

https://www.phoronix.com/forums/forum/linux-graphics-x-org-drivers/opengl-vulkan-mesa-gallium3d/38705-is-llvm-strictly-required-for-building-mesa-gallium-radeon

But it is need to be checked.

[Gwang-Jin]

@dpo I have a question: Is it more precise

   depends_on "linuxbrew/xorg/dri2proto"
   depends_on "linuxbrew/xorg/glproto"
   depends_on "linuxbrew/xorg/kbproto" if build.with? "libva"
   depends_on "linuxbrew/xorg/xextproto" if build.with? "libva"
   depends_on "linuxbrew/xorg/xf86vidmodeproto" if build.with? "libva"
   depends_on "linuxbrew/xorg/fixesproto" if build.with? "libva"

?

kbproto, xextproto, xf86vidmodeproto ,and fixesproto weren't need to be build mesa without libva.

Ok. I will try to check them using ci/circleci.

[dpo]

We're back to

checking for x11 xext xdamage >= 1.1 xfixes x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8... no
configure: error: Package requirements (x11 xext xdamage >= 1.1 xfixes x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8) were not met:

Package 'kbproto', required by 'x11', not found

It looks like kbproto is needed, even without libva.

[Gwang-Jin]

Ok. I removed "if build.with? "libva"". It would pass ci/circlei.

[dpo]

Looks good! Many thanks! Would you mind making llvm support optional, as suggested by @maxim-belkin?

[Gwang-Jin]

Regarding --without-llvm, only r600 driver can be used. It would be possible. And I would like to add an option --with-gallium-osmesa (Disable the older classic OSMesa in favor of the newer gallium OSMesa). But these options are conflict. --with-gallium-osmesa requires --with-gallium-drivers=swrast,swr. So I want to finish this PR here and will try another PR. Thanks.

[dpo]

@maxim-belkin Is there something holding this up?

[maxim-belkin]

Thanks, @Gwang-Jin and @dpo!
I've tested this locally and mesa builds fine with it. As I mentioned before, the plan is to make llvm dependency optional but your solution is good until we do that.

[dpo]

Great! Thank you.