Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EU Issues #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

scaccoman
Copy link

Hi @maxinminax, I'm located in the EU and I've recently purchased a few Xiaomi smart home devices. While testing the NPM package, I found a couple of issues that I believe are the result of my Mi Account region settings (DE):

  1. The Miio Device constructor doesn't allow to specify a country different than the default CN, this causes Mi Cloud calls to be performed to the Chinese API URL (which returns nothing).
  2. Although further testing would be required to be 100% sure, I believe that the region settings influence the properties that can be retrieved for a given device. While testing with my viomi.vacuum.v7, multiple properties (defined in the device class) weren't available, I believe it's better to have a soft check for the length of the properties rather than throwing an invisible error.

Please let me know if there's anything I should change and/or improve, I'd be happy to contribute to the project on a regular basis.

@Pittini
Copy link
Contributor

Pittini commented Mar 11, 2021

Hi @scaccoman ,
i'm also located in EU/DE and using node-mihome together with iobroker in this skript. For me, there is no problem with de or cn cloud, it works fine. So maybe, your problem is located elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants