replace telefonica peru with movistar peru as isp name #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhogan8
reviewed
Jul 16, 2024
| @@ -77,7 +77,7 @@ and branding conventions: | |||
| | `Versatel Deutschland` | `1&1 Versatel` | | |||
| | `Telefonica O2 UK` | `O2 UK` | | |||
| | `INDOSAT Internet Network Provider` | `Indosat` | | |||
| | `Telefonica del Peru` | `Telefonica Peru` | | |||
| | `Telefonica del Peru` | `Movistar Peru` | | |||
There was a problem hiding this comment.
Nitpick, but there's some additional white space after Movistar Peru
There was a problem hiding this comment.
so i added it to make the vertical lines at the end line up, they didn't until I did that -- I checked and they all have extra spacing added :)
There was a problem hiding this comment.
i've just had another change come through for this same release note so i'm going to add it to this PR if that's okay, we can review again tomorrow.
There was a problem hiding this comment.
@dhogan8 this is ready for another look when you have a bit of time :) Thanks!
There was a problem hiding this comment.
Oops! My bad and good catch.
There was a problem hiding this comment.
not at all, i appreciate it!! thanks!!
dhogan8
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.