Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace telefonica peru with movistar peru as isp name #1159

Merged
merged 2 commits into from
Jul 17, 2024
Merged

replace telefonica peru with movistar peru as isp name #1159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b62ad
replace telefonica peru with movistar peru as isp name
Jul 16, 2024
ba59a25
remove line about orange mobile to ee mobile
Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions content/geoip/release-notes/2024.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ and branding conventions:
| `Versatel Deutschland` | `1&1 Versatel` |
| `Telefonica O2 UK` | `O2 UK` |
| `INDOSAT Internet Network Provider` | `Indosat` |
| `Telefonica del Peru` | `Telefonica Peru` |
| `Orange Mobile` | `EE Mobile` |
| `Telefonica del Peru` | `Movistar Peru` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but there's some additional white space after Movistar Peru

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so i added it to make the vertical lines at the end line up, they didn't until I did that -- I checked and they all have extra spacing added :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've just had another change come through for this same release note so i'm going to add it to this PR if that's okay, we can review again tomorrow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhogan8 this is ready for another look when you have a bit of time :) Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! My bad and good catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not at all, i appreciate it!! thanks!!

| `TDC Danmark` | `TDC Net` |
| `T-mobile Polska` | `T-Mobile Polska` |
| `Atlantic Broadband` | `Breezeline` |
Expand Down
Loading