Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create WebServiceClient interface to enable easier mocking #152

Merged
merged 1 commit into from Sep 8, 2022

Conversation

igobl
Copy link
Contributor

@igobl igobl commented Aug 23, 2022

Allows mocking of WebServiceClient without needing knowledge of underlying http requests that are being made.

Allows mocking of WebServiceClient without needing knowledge of underlying http requests that are being made.
Copy link
Member

@oschwald oschwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oschwald oschwald merged commit 6b7c2a1 into maxmind:main Sep 8, 2022
oschwald added a commit that referenced this pull request Sep 8, 2022
oschwald added a commit that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants