Make IP address optional when reporting transactions #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
requested changes
May 28, 2024
src/request/transaction-report.ts
Outdated
| * The IP address of the customer placing the order. | ||
| * The IP address of the customer placing the order. This field is not | ||
| * required if you provide at least one of the transaction's minfraud_id, | ||
| * maxmind_id, or transaction_id. You are encouraged to provide it, if |
There was a problem hiding this comment.
Maybe the casung should match the names in this interface (which also match the names used elsewhere in this package).
CHANGELOG.md
Outdated
|
|
||
| * Updated `TransactionReport` to make the `ipAddress` parameter optional. Now | ||
| the `tag` and at least one of the following paramters must be supplied: | ||
| `ipAddress`, `maxmindId`, `minfraudID`, `transactionID`. |
There was a problem hiding this comment.
Suggested change
| `ipAddress`, `maxmindId`, `minfraudID`, `transactionID`. | |
| `ipAddress`, `maxmindId`, `minfraudId`, `transactionId`. |
oschwald
requested changes
Jun 6, 2024
| @@ -50,7 +54,7 @@ export default class TransactionReport { | |||
| /** @inheritDoc TransactionReportProps.chargebackCode */ | |||
| public chargebackCode?: string; | |||
| /** @inheritDoc TransactionReportProps.ipAddress */ | |||
| public ipAddress: string; | |||
| public ipAddress?: string; | |||
There was a problem hiding this comment.
Hmm, this seems like a breaking change too. We should probably do a major version bump.
oschwald
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.