Support embedding video #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the quick-start.
…ing to including gatsby-remark-images twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes video support by default, with a demonstration page modeled on the image demonstration page. Interested?
Adding video support turned out to be a little fiddly due to interactions with the other plugins, so I thought it might be worth including doing it the "right" way directly in the starter.
I'm not sure how best to handle duplicating plugins between the gatsby-transformer-remark entry and gatsbyRemarkPlugins. gatsbyjs/gatsby#15486 is theoretically resolved, but appears to not always be resolved for everyone (gatsbyjs/gatsby#15486 (comment)). We could probably remove the duplication (including both gatsby-remark-images and gatsby-remark-embed-video) but it might be worth keeping a few more months so that someone trying to use the starter doesn't get blindsided by an unforeseen leftover of gatsbyjs/gatsby#15486