Declare this.map as empty array #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declaring this.map prevents "Cannot read property length of null" error (e.g. from line 392). Error occurs if all Vivus objects are set to display: none;, for example.
|
Nice catch. Even if I would say that an SVG which doesn't have anything to
display is invalid, but it should trigger an error once the SVG is loaded
when this condition can be checked.
Otherwise, some methods (especially about status) will not return a logic
value.
|
|
Actually it doesn't call the Thanks for your help (and sorry for the delay) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring
this.mapas an empty array preventsCannot read property length of nullerror (e.g. from vivus.js:392). Error occurs if all Vivus objects are set todisplay: none;, for example.