Fixes syncing getting stuck at intervals of 500 blocks. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is Proof of Stake blocks are not stored when the previous transaction of the CoinStake is missing. So the initial download process is broken. To solve this: The reference block is now the best block, whatever the proof. The client asks for missing blocks when it receives a PoS block and it doesn't have the CoinStake previous transaction. Block request are retried immediately during initial download because the same last block is asked multiple times until we have the full chain. Solution inspired by Sigmike.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is Proof of Stake blocks are not stored when the previous transaction of the CoinStake is missing. So the initial download process is broken.
To solve this:
The reference block is now the best block, whatever the proof.
The client asks for missing blocks when it receives a PoS block and
it doesn't have the CoinStake previous transaction.
Block request are retried immediately during initial download because
the same last block is asked multiple times until we have the full
chain.
Solution by Sigmike.