Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build bulk selection UI for transactions #798

Closed
5 tasks
zachgoll opened this issue May 23, 2024 · 2 comments · Fixed by #840
Closed
5 tasks

Build bulk selection UI for transactions #798

zachgoll opened this issue May 23, 2024 · 2 comments · Fixed by #840

Comments

@zachgoll
Copy link
Collaborator

zachgoll commented May 23, 2024

Image

Feature Overview

The purpose of this issue is to create UI controls to select 1 or more transactions and perform various actions on those transactions.

Not in Scope

This issue will NOT cover the actual updates—it is solely UI focused. Placeholders and cursor-not-allowed states should be added over the form submissions for now.

Requirements

If there is a missing / incorrect requirement, please leave a comment before starting work on this.

  • User can see select checkbox on each transaction
  • User can select 1 or more transactions
  • When selected, a bar at the bottom appears that says how many are selected
    • User sees an edit icon (placeholder, cursor-not-allowed)
    • User sees a delete icon (placeholder, cursor-not-allowed)

Implementation Suggestions

Below are some ideas for implementation to get you started. Use your best judgment here—if there's a better way to do things, go for it!

Designs

Below are the designs you should follow while implementing this:
https://www.figma.com/design/lonJmVk3HYkwZoIO7xYP2w/Maybe-App-(Community)?node-id=3626-2572

Reminders

  • Make sure to review our contributing guidelines before starting on an issue
  • We do our best to define a clear spec for new features and fixes, but think of them as "suggestions", not "hard requirements". We welcome ideas and suggestions!
    • If you see missing requirements to this issue, please leave a comment below explaining what is missing and why it is important.
    • If you see a requirement that you think is incorrect or not optimal, please leave a comment explaining what you think needs to change below.
@scubamaggo
Copy link
Contributor

I have tinkered with this a bit and during the implementation noticed that we have a second transaction list: The one on the dashboard.
My initial gut feeling when using the checkboxes was that they do not belong on the dashboard view, but should be kept to the Transactions view as seen in the issue description.

What is the general opinion on that?

@zachgoll
Copy link
Collaborator Author

@scubamaggo I agree with this. I'm working on cleaning up some of that in #795 which will probably make this issue quite a bit easier to work with.

I'm going to go ahead and mark this as "Planning" in the project as I think #795 should probably be completed first. If you have some ideas feel free to leave them on that issue and I'll try to get them implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants