Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction sidebar, partials, and controller cleanup #795

Closed
4 tasks
zachgoll opened this issue May 22, 2024 · 0 comments · Fixed by #817
Closed
4 tasks

Transaction sidebar, partials, and controller cleanup #795

zachgoll opened this issue May 22, 2024 · 0 comments · Fixed by #817
Assignees
Labels
💡 Improvement Improvements to an existing feature or flow

Comments

@zachgoll
Copy link
Collaborator

Up to this point, we've done a lot of exploratory work with transaction-related views and have intentionally avoided any refactors to optimize for speed.

There are some issues that need to be addressed as they are starting to slow down development.

I'm keeping this issue somewhat general as there are likely improvements to be made that are not listed below in this initial roundup:

  • Fix form submission issues with the transaction sidebar (it may help to pass a ?transaction= while on the /transactions view to know the currently opened drawer is and allow for non-turbo form submissions)
  • Move controller logic to model
  • Clean up model
  • Consolidate and organize partials (there are a lot of similar names)

As mentioned above, there are likely more issues to address here, but the overall goal is to clean up the transactions module of the codebase a bit so we can continue to develop new features quickly.

@zachgoll zachgoll added the 💡 Improvement Improvements to an existing feature or flow label May 22, 2024
@zachgoll zachgoll self-assigned this May 23, 2024
@zachgoll zachgoll linked a pull request May 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Improvement Improvements to an existing feature or flow
Projects
Development

Successfully merging a pull request may close this issue.

1 participant