-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Currency Part 2 #543
Merged
zachgoll
merged 22 commits into
main
from
525-clean-up-multi-currency-support-implementation
Mar 21, 2024
Merged
Multi-Currency Part 2 #543
zachgoll
merged 22 commits into
main
from
525-clean-up-multi-currency-support-implementation
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up-multi-currency-support-implementation
Still a good number of follow-up PRs required beyond this one, but the core sync process for handling multi-currency accounts along with the associated tests are in. |
Will revisit this after #553 is merged (lots of code overlap) |
…up-multi-currency-support-implementation
…up-multi-currency-support-implementation
…up-multi-currency-support-implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While the current app is built to support multi-currency, there are a few critical flows that still need to be implemented to support multi-currency.
This PR aims to introduce "v1" multi-currency support with:
Money
andMoney::Currency
classes (similar tomoney
gem, but much simpler implementation tailored to our use case with major currency units and BigDecimal DB types)Money::Currency.all
)EUR
andUSD/EUR
(multicurrency) account to both demo user and test fixturesFamily.currency
Remaining tasks
Family.currency