Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Currency Part 2 #543

Merged
merged 22 commits into from
Mar 21, 2024

Conversation

zachgoll
Copy link
Collaborator

@zachgoll zachgoll commented Mar 11, 2024

Overview

While the current app is built to support multi-currency, there are a few critical flows that still need to be implemented to support multi-currency.

This PR aims to introduce "v1" multi-currency support with:

  • Money and Money::Currency classes (similar to money gem, but much simpler implementation tailored to our use case with major currency units and BigDecimal DB types)
  • Support for all major currencies (see Money::Currency.all)
  • Adds both a EUR and USD/EUR (multicurrency) account to both demo user and test fixtures
  • Updates the account sync process to normalize historical account balances to a common currency defined by Family.currency
  • Handles an "opt-in" exchange rates setup flow with Synth APIs for users who have accounts in multiple currencies
  • Offers "on-demand" exchange rate syncs from Synth APIs

Remaining tasks

  • Add exchange rates for fixtures
  • Update account sync to convert balances to common Family.currency
  • Update tests to expect multi-currency results
  • Update all places in UI where multi-currency applies

@zachgoll zachgoll linked an issue Mar 11, 2024 that may be closed by this pull request
@zachgoll zachgoll marked this pull request as ready for review March 13, 2024 22:54
@zachgoll
Copy link
Collaborator Author

Still a good number of follow-up PRs required beyond this one, but the core sync process for handling multi-currency accounts along with the associated tests are in.

@zachgoll
Copy link
Collaborator Author

Will revisit this after #553 is merged (lots of code overlap)

@zachgoll zachgoll marked this pull request as ready for review March 21, 2024 15:35
@zachgoll zachgoll merged commit 110855d into main Mar 21, 2024
4 checks passed
@zachgoll zachgoll deleted the 525-clean-up-multi-currency-support-implementation branch March 21, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-Currency Support Implementation
1 participant