Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guest_os_type options for puppet provisioner #74

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

mprince
Copy link
Contributor

@mprince mprince commented Oct 17, 2017

Issue

closes #72

List of Changes Proposed

Add guest_os_type options for puppet provisioner

Testing Evidence

Example Script

from packerlicious import provisioner, Template

provisioners = [
    provisioner.PuppetMasterless(manifest_file="site.pp", guest_os_type="windows"),
    provisioner.PuppetServer(guest_os_type="unix")
]

t = Template()
t.add_provisioner(provisioners)

print(t.to_json())

Results

{
  "provisioners": [
    {
      "guest_os_type": "windows",
      "manifest_file": "site.pp",
      "type": "puppet-masterless"
    },
    {
      "guest_os_type": "unix",
      "type": "puppet-server"
    }
  ]
}

If the value provided is not in ["windows", "unix"] following error

ValueError: String must be one of following: unix, windows

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 81.746% when pulling 215fe4c on mprince:issue72 into 43665de on mayn:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 81.944% when pulling ebba443 on mprince:issue72 into 43665de on mayn:master.

@mayn mayn added this to the 0.6.0 milestone Oct 17, 2017
Copy link
Owner

@mayn mayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayn mayn merged commit 9d6a51a into mayn:master Oct 17, 2017
@mprince mprince deleted the issue72 branch October 17, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provisioner/puppet add guest_os_type
3 participants