-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
elementary/src/grid/SearchGrid.tsx
Outdated
} catch (exception) { | ||
const err = errorise(exception) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to throw anything in JS, this ensures that code below that expects only Error
s doesn't accidentally get something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚃
I converted this to draft as I encountered much more issues than originally expected |
Forgot to push the last experiments. Still failing, but much closer to something working now. Mostly blocked on this question |
* Fix the issue with base64 import * Remove yarn interactive tools * Remove sily coment
…/authCodeMsalBrowser
Current progress
Next steps
Blockers that can be worked around for local testingSome foundational libs that we use currently refuse to work in ESM mode which will likely be a hard blocker:
To workaround these issues locally it's possible to hot-fix respective # @emotion/react/package.json
+ "exports": {
+ ".": {
+ "import": "./dist/emotion-react.esm.js",
+ "types": "./types/index.d.ts"
+ },
+ "./jsx-runtime": {
+ "import": "./jsx-runtime/dist/emotion-react-jsx-runtime.esm.js",
+ "types": "./types/jsx-runtime.d.ts"
+ },
+ "./jsx-dev-runtime": {
+ "import": "./jsx-dev-runtime/dist/emotion-react-jsx-dev-runtime.esm.js",
+ "types": "./types/jsx-dev-runtime.d.ts"
+ }
+ } # react/package.json
+ "exports": {
+ ".": {
+ "react-server": "./unstable-index.server.js",
+ "default": "./index.js"
+ },
+ "./index": {
+ "react-server": "./unstable-index.server.js",
+ "default": "./index.js"
+ },
+ "./build-info.json": "./build-info.json",
+ "./jsx-runtime": "./jsx-runtime.js",
+ "./jsx-dev-runtime": "./jsx-dev-runtime.js"
+ } One less critical lib is also impacted:
|
This PR attempted to not only upgrade Typescript, but also to switch to ECMAScript Modules. ECMAScript Modules came up only due to issues with Jest and since they cause an enormous amount of trouble I think this effort should be put aside until ESM ecosystem matures more. If we want to get newer versions of Typescript sooner, we should have another go but this time specifically try to do whatever it takes to not enable ESM. |
At long last, this was finally done in #766 |
This unlocks a couple of nifty features in my IDE (in addition to better typechecking, of course :P )