Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

Upgraded react router to 6.11.1 #766

Merged
merged 6 commits into from
May 11, 2023
Merged

Conversation

akindyakov
Copy link
Contributor

@akindyakov akindyakov commented May 10, 2023

Main reason is to avoid Users getting stack on non-existing paths such as https://mazed.se/login when user is already logged in. Saw that couple of times during the onboarding myself.

  • Upgraded react router to 6.11.1.
  • Upgraded: ts-loader up to ^9.4.2
  • Upgraded: typescript up to 4.7.3.
  • Disabled some tests because of bloody Jest - have no time to deal with it now. Next time jest, next time (I'll replace it with something like baretest).
  • Deleted bunch of dead code such as Jinn for editor.
  • Moved SearchGrid component to truthsayer to drop dependency on react-router from elementary.
  • Converted some components from JS to TS to fix issues of migration.
  • Dropped couple of unused dependencies.

@akindyakov akindyakov added bug Something isn't working fix labels May 10, 2023
Copy link
Collaborator

@SergNikitin SergNikitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christmas came early!!!! Fantastic 😍 I bashed my head against a conversion to a less obsolete typescript version for too long

@SergNikitin SergNikitin merged commit 77ee7ab into main May 11, 2023
@SergNikitin SergNikitin deleted the upgrade-react-router-and-clean-up branch May 11, 2023 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants