Skip to content

Commit

Permalink
CI/azure: fix flakiness by avoiding libtool wrappers
Browse files Browse the repository at this point in the history
Install curl binaries into MinGW bin folder and use that
for the tests in order to avoid libtool wrapper binaries.

The libtool wrapper binaries (not scripts) on Windows seem
to be the root cause of the following issues:

1. Process output can be lost in the wrapper process chain.
2. Killing the wrapper process does not kill the real one.

Reviewed-by: Daniel Stenberg

Derived from curl#5904
Closes curl#6049
  • Loading branch information
mback2k committed Oct 8, 2020
1 parent 1101fbb commit 027adea
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions .azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ stages:
displayName: 'configure $(name)'

- script: make
displayName: 'make'
displayName: 'make && cd tests && make'

- script: make test-nonflaky
displayName: 'test'
Expand Down Expand Up @@ -188,11 +188,14 @@ stages:
- script: $(container_cmd) -l -c "cd $(echo '%cd%') && ./buildconf && ./configure $(configure)"
displayName: 'configure $(name)'

- script: $(container_cmd) -l -c "cd $(echo '%cd%') && make"
- script: $(container_cmd) -l -c "cd $(echo '%cd%') && make && cd tests && make"
displayName: 'make'

- script: $(container_cmd) -l -c "cd $(echo '%cd%') && make install && find tests -type f -path '*/.libs/*.exe' -execdir mv -t .. {} \;"
displayName: 'install'

- script: $(container_cmd) -l -c "cd $(echo '%cd%') && make test-nonflaky"
displayName: 'test'
env:
AZURE_ACCESS_TOKEN: "$(System.AccessToken)"
TFLAGS: "-r $(tests)"
TFLAGS: "-c curl.exe -r $(tests)"

0 comments on commit 027adea

Please sign in to comment.