Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intuitive selection #42

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Intuitive selection #42

merged 2 commits into from
Mar 10, 2022

Conversation

mbaeuerle
Copy link
Owner

This PR will introduce a new way of how crop rects are selected.
Prevously:

  • Resizing a rect was possible without being selected
  • Selection/deselection was done with ctrl + click
  • Moving and scaling multiple rects synchronous was only possible while holding shift

With this PR:

  • Clicking on a rect will select it
  • Shift + click adds a rect to the selection (or removes it if it was already part of it)
  • Deselection of all rects is done by either
    • clicking anywhere else but the selected rects
    • pressing ESC
    • A new selection is started by clicking on a rect which was not selected before (without shift)
  • Moving and scaling multiple rects synchronously is now done without a modifier

I think that is a more natural way for selecting objects, less cumbersome and is also more familiar from other tools like Powerpoint, Keynote, etc.

@mbaeuerle mbaeuerle requested a review from cleydyr March 10, 2022 21:45
@cleydyr
Copy link
Collaborator

cleydyr commented Mar 10, 2022

Hey, @mbaeuerle . I've made just a comment in the PR with a suggestion. Other than that, it looks good to me.

Regards

@mbaeuerle
Copy link
Owner Author

@cleydyr thanks for reviewing. Maybe I'm a bit blind today, but unfortunately I could not find your comment. Maybe it's still pending?

@cleydyr
Copy link
Collaborator

cleydyr commented Mar 10, 2022

Didn't mention you. 🤦 I thought Github would notify you anyway. Fixed.

@mbaeuerle
Copy link
Owner Author

mbaeuerle commented Mar 10, 2022

@cleydyr Still cannot see any comment 😮 if you started a review (instead of writing a single comment) you need to submit it first before I can see it. Otherwise the comments are still in pending state.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#submitting-your-review

@mbaeuerle mbaeuerle merged commit 67c0054 into master Mar 10, 2022
@mbaeuerle mbaeuerle deleted the feature/intuitive-selection branch March 10, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants