Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in calculation resistance factor resfac in LeakyLineDoublet #71

Closed
dbrakenhoff opened this issue Jun 14, 2023 · 1 comment · Fixed by #70
Closed

Bug in calculation resistance factor resfac in LeakyLineDoublet #71

dbrakenhoff opened this issue Jun 14, 2023 · 1 comment · Fixed by #70
Labels

Comments

@dbrakenhoff
Copy link
Collaborator

The resistance factor in LeakyLineDoublet is calculated as T / res, when this should be aquifer thickness / res. The value of the flux is therefore off by factor kaq.

dbrakenhoff added a commit that referenced this issue Jun 14, 2023
- resfac fixed in LineDoublet(1d)
- resfac fixed in LineSink(1d)
@dbrakenhoff dbrakenhoff linked a pull request Jun 14, 2023 that will close this issue
4 tasks
@mbakker7
Copy link
Owner

Other way to put it: The resistance of the leaky layer is really res / kaq. That is not desired, of course and should be fixed.

@mbakker7 mbakker7 added the bug label Jun 14, 2023
mbakker7 pushed a commit that referenced this issue Jul 5, 2023
* Add LeakyBuildingPit element
- add LeakyIntHeadDiffEquation mixin class
- add LeakyIntHeadDiffLineSink element for leaky pit boundaries with leaky walls
- add LeakyBuildingPit element, inherits from BuildingPit but adds resistance term
- add notebook testing LeakyBuildingPit

allow BuildingPit to be placed in models with 1 layer
isort __init__

* use self.disveclayers for RHS

* fix #71
- resfac fixed in LineDoublet(1d)
- resfac fixed in LineSink(1d)

* update leaky building pit nb

* allow passing kwargs to contour func

* add integration of normal flux along line
- add disvecnorm: calculate disvec normal to angle theta
- intdisvecnorm: quad/legendre integration of disvecnorm
- add quad integrand function for integrating from 0->r

* rename *disvecnorm to *normflux
- improve code and docstring

* fix overwrite of label kwarg

* add intnormflux notebook

* add intnormflux notebook

* add quad_vec import

* improve normal flux nb

* optimize code a bit and reorder coordinates

* update normalflux nb

* docstrings normflux functions

* add circular leaky building pit notebook

* rename to IntLeakyWallEquation

* rename to IntLeakyWallEquation

* delete nb

* remove py3.7 testing, add 3.10 and 3.11

* fix buildingpit nb

* add shapely to ci reqs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants