Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LeakyBuildingPit element #70

Merged
merged 23 commits into from Jul 5, 2023
Merged

Add LeakyBuildingPit element #70

merged 23 commits into from Jul 5, 2023

Conversation

dbrakenhoff
Copy link
Collaborator

@dbrakenhoff dbrakenhoff commented Jun 8, 2023

PR for LeakyBuildingPit element, plus some other developments:

Add LeakyBuildingPit elements (#72):

  • add IntLeakyWallEquation mixin class
  • add LeakyIntHeadDiffLineSink element for building pit with leaky walls
  • add LeakyBuildingPit element, inherits from BuildingPit but adds resistance term
  • add notebook testing LeakyBuildingPit by comparing to exact analytical solution for circular building pit

Add integrated normal flux method to model class (#60)

  • Add ml.intnormflux() for calculating flux flowing over a specified line.
  • Implement two integration methods (approximate analytical integration with legendre-quadrature and numerical intergration with scpy quad)
  • Add notebook testing normflux methods.

Fix bug in resistance factor calculations (#71)

  • Replace resfac = T / res by resfac = Haq / res. Tested by comparing LeakyLineDoublet solution to exact analytical solution for circular building pit.

Other changes:

  • Drop Python 3.7 testing, add 3.10 and 3.11. (Drop Python 3.7 support #73)
  • allow BuildingPit to be placed in models with 1 layer
  • isort __init__.py
  • allow passing kwargs to contour function

TODO:

  • check solution
  • check naming of the elements (Leaky for resistance term?, Int for integrated condition?, HeadDiff for change inside-outside?, ...)
  • add tests
  • documentation

- add LeakyIntHeadDiffEquation mixin class
- add LeakyIntHeadDiffLineSink element for leaky pit boundaries with leaky walls
- add LeakyBuildingPit element, inherits from BuildingPit but adds resistance term
- add notebook testing LeakyBuildingPit

allow BuildingPit to be placed in models with 1 layer
isort __init__
@dbrakenhoff dbrakenhoff requested a review from mbakker7 June 8, 2023 13:57
@dbrakenhoff dbrakenhoff linked an issue Jun 14, 2023 that may be closed by this pull request
@dbrakenhoff dbrakenhoff linked an issue Jun 14, 2023 that may be closed by this pull request
@dbrakenhoff dbrakenhoff marked this pull request as ready for review July 5, 2023 13:46
This was linked to issues Jul 5, 2023
@dbrakenhoff dbrakenhoff self-assigned this Jul 5, 2023
@mbakker7 mbakker7 merged commit 51ad165 into master Jul 5, 2023
5 checks passed
@mbakker7 mbakker7 deleted the leakypit branch July 5, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants