git versioning: add method to check if git is available #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do you check specifically against git major version 2? |
|
|
| static boolean isGitVersioningAvailable() { | ||
| try { | ||
| String output = getCommandOutput("git --version") | ||
| return output.contains("2.") |
There was a problem hiding this comment.
git 3.2.0 will match this :) How about output.startsWith("git version 2")?
As discussed in code review we shoul look for a string starting with
"git version 2" instead of looking for just `contains("2")`.
|
I double checked with the windows version of git and |
joao-silveira
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a helper method to check if git is available so that build scripts can handle this case gracefully instead of catching the exceptions thrown form the underlying API.