Content-Security-Policy compatibility #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert `admin/img/icon-alert.svg` to data-uri to avoid referencing static files in css Convert css to proper css file, move it to static folder. Pass required variables for javascript as `rosetta-settings-js` json. Convert js to proper js file, move it to static folder. Move inline style for `action-toggle` to stylesheet file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
admin/img/icon-alert.svgto a data URI to avoid referencing static files in CSS.rosetta.cssto a proper CSS file and move it to the static folder.rosetta_settings_jscontext variable.rosetta_settings_jscontains relevant settings and variables for JavaScript.rosetta.jsto a proper JS file and move it to the static folder.action-toggleto the stylesheet file.ref: #287
All Submissions:
pip install tox && tox)No
No