Remove java.toolchain from build, fix Win arm64 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #73, running `.\gradlew.bat build` on arm64 Windows would fail with "WindowsRegistry is not supported on this operating system." Removing the `java.toolchain` block from strcalc/build.gradle.kts allows it to succeed, as Gradle no longer tries to query the Windows registry to discover the Java toolchain. It will just pick up the toolchain from the environment. Running `.\gradlew.bat -q javaToolchains` will still produce the failure, however. See: - https://docs.gradle.org/current/userguide/toolchains.html - gradle/native-platform: WindowsRegistry is not supported on this operating system. #274 gradle/native-platform#274 (comment) - gradle/gradle: Support ARM64 Windows #21703 gradle/gradle#21703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #73, running
.\gradlew.bat buildon arm64 Windows would fail with "WindowsRegistry is not supported on this operating system." Removing thejava.toolchainblock from strcalc/build.gradle.kts allows it to succeed, as Gradle no longer tries to query the Windows registry to discover the Java toolchain. It will just pick up the toolchain from the environment.Running
.\gradlew.bat -q javaToolchainswill still produce the failure, however.See: