Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1 breaks in all but 1 window #1470

Closed
visua0 opened this issue Feb 19, 2024 · 1 comment
Closed

F1 breaks in all but 1 window #1470

visua0 opened this issue Feb 19, 2024 · 1 comment

Comments

@visua0
Copy link

visua0 commented Feb 19, 2024

Steps to reproduce

  • Open Firefox in new profile
  • Install Sidebery
  • Open at least 1 other window
  • Go to about:addons and toggle sidebery off and on

Expected behavior

Sidebery continues working normally.

Actual behavior

F1 (open/close sidebar panel) stops working in all but 1 window.
When this happens naturally in my main profile it also makes my sidebars blank (showing only the background color) in every window. Sadly I don't know what causes this to happen naturally, but it's been happening at least once a day the past several days or so. Never happened to me before.
In this case toggling the extension in about:addons gets my tabs to show up again, but it does not fix F1.
Note that in my main profile where this naturally occurs I am using the nightly version, but I was able to reproduce the F1 bug with 5.1.1 from AMO.
I also got the blank sidebar once with 5.1.1 just now when I loaded an old profile containing sidebery 4, which then showed the upgrade process to 5 in the sidebar, and immediately after it went blank.
I'm not 100% sure but the F1 and blank sidebar issues sure seem related.

Debug info

I get this error in the browser console every time I hit F1 in a window where it does not work:

TypeError: this.extension is null ext-sidebarAction.js:386:9
    triggerAction chrome://browser/content/parent/ext-sidebarAction.js:386
    buildKey resource://gre/modules/ExtensionShortcuts.sys.mjs:467

This might be unrelated since it also happens before triggering the bug (so while F1 is still working in all windows), but when I open a new window I get this:

this._switcherPanel is null browser-sidebar.js:269
    updateShortcut chrome://browser/content/browser-sidebar.js:269
    registerKeysToDocument resource://gre/modules/ExtensionShortcuts.sys.mjs:425
    windowOpenListener resource://gre/modules/ExtensionShortcuts.sys.mjs:317
    handleEvent chrome://extensions/content/parent/ext-tabs-base.js:1723
Addon data
{
  "addonVersion": "5.1.1",
  "firefoxVersion": "122.0.1",
  "settings": {
    "nativeScrollbars": true,
    "nativeScrollbarsThin": true,
    "nativeScrollbarsLeft": false,
    "selWinScreenshots": false,
    "updateSidebarTitle": true,
    "markWindow": false,
    "markWindowPreface": "[Sidebery] ",
    "ctxMenuNative": false,
    "ctxMenuRenderInact": true,
    "ctxMenuRenderIcons": true,
    "ctxMenuIgnoreContainers": "",
    "navBarLayout": "horizontal",
    "navBarInline": true,
    "navBarSide": "left",
    "hideAddBtn": false,
    "hideSettingsBtn": false,
    "navBtnCount": true,
    "hideEmptyPanels": true,
    "hideDiscardedTabPanels": false,
    "navActTabsPanelLeftClickAction": "none",
    "navActBookmarksPanelLeftClickAction": "none",
    "navTabsPanelMidClickAction": "discard",
    "navBookmarksPanelMidClickAction": "none",
    "navSwitchPanelsWheel": true,
    "subPanelRecentlyClosedBar": true,
    "subPanelBookmarks": true,
    "subPanelHistory": true,
    "groupLayout": "grid",
    "containersSortByName": false,
    "skipEmptyPanels": false,
    "dndTabAct": true,
    "dndTabActDelay": 750,
    "dndTabActMod": "none",
    "dndExp": "pointer",
    "dndExpDelay": 750,
    "dndExpMod": "none",
    "dndOutside": "win",
    "dndActTabFromLink": true,
    "dndActSearchTab": true,
    "dndMoveTabs": false,
    "dndMoveBookmarks": false,
    "searchBarMode": "dynamic",
    "searchPanelSwitch": "same_type",
    "searchBookmarksShortcut": "",
    "searchHistoryShortcut": "",
    "warnOnMultiTabClose": "collapsed",
    "activateLastTabOnPanelSwitching": true,
    "activateLastTabOnPanelSwitchingLoadedOnly": true,
    "switchPanelAfterSwitchingTab": "always",
    "tabRmBtn": "hover",
    "activateAfterClosing": "next",
    "activateAfterClosingStayInPanel": false,
    "activateAfterClosingGlobal": false,
    "activateAfterClosingNoFolded": true,
    "activateAfterClosingNoDiscarded": true,
    "askNewBookmarkPlace": true,
    "tabsRmUndoNote": true,
    "tabsUnreadMark": false,
    "tabsUpdateMark": "all",
    "tabsUpdateMarkFirst": true,
    "tabsReloadLimit": 5,
    "tabsReloadLimitNotif": true,
    "showNewTabBtns": true,
    "newTabBarPosition": "after_tabs",
    "tabsPanelSwitchActMove": false,
    "tabsPanelSwitchActMoveAuto": true,
    "tabsUrlInTooltip": "full",
    "newTabCtxReopen": false,
    "tabWarmupOnHover": true,
    "tabSwitchDelay": 0,
    "moveNewTabPin": "start",
    "moveNewTabParent": "last_child",
    "moveNewTabParentActPanel": false,
    "moveNewTab": "end",
    "moveNewTabActivePin": "start",
    "pinnedTabsPosition": "panel",
    "pinnedTabsList": false,
    "pinnedAutoGroup": false,
    "pinnedNoUnload": false,
    "pinnedForcedDiscard": false,
    "tabsTree": true,
    "groupOnOpen": true,
    "tabsTreeLimit": "none",
    "autoFoldTabs": false,
    "autoFoldTabsExcept": "none",
    "autoExpandTabs": false,
    "autoExpandTabsOnNew": false,
    "rmChildTabs": "folded",
    "tabsLvlDots": true,
    "discardFolded": false,
    "discardFoldedDelay": 0,
    "discardFoldedDelayUnit": "sec",
    "tabsTreeBookmarks": true,
    "treeRmOutdent": "branch",
    "ignoreFoldedParent": false,
    "colorizeTabs": false,
    "colorizeTabsSrc": "domain",
    "colorizeTabsBranches": false,
    "colorizeTabsBranchesSrc": "url",
    "inheritCustomColor": true,
    "hideInact": false,
    "hideFoldedTabs": false,
    "hideFoldedParent": "none",
    "nativeHighlight": false,
    "warnOnMultiBookmarkDelete": "collapsed",
    "autoCloseBookmarks": false,
    "autoRemoveOther": false,
    "highlightOpenBookmarks": false,
    "activateOpenBookmarkTab": false,
    "showBookmarkLen": true,
    "bookmarksRmUndoNote": true,
    "loadBookmarksOnDemand": true,
    "pinOpenedBookmarksFolder": true,
    "oldBookmarksAfterSave": "ask",
    "loadHistoryOnDemand": true,
    "fontSize": "m",
    "animations": true,
    "animationSpeed": "norm",
    "theme": "proton",
    "density": "default",
    "colorScheme": "ff",
    "sidebarCSS": false,
    "groupCSS": false,
    "snapNotify": true,
    "snapExcludePrivate": false,
    "snapInterval": 0,
    "snapIntervalUnit": "min",
    "snapLimit": 0,
    "snapLimitUnit": "snap",
    "snapAutoExport": false,
    "snapAutoExportType": "json",
    "snapAutoExportPath": "Sidebery/snapshot-%Y.%M.%D-%h.%m.%s",
    "snapMdFullTree": false,
    "hScrollAction": "none",
    "onePanelSwitchPerScroll": false,
    "navSwitchPanelsDelay": 128,
    "scrollThroughTabs": "none",
    "scrollThroughVisibleTabs": true,
    "scrollThroughTabsSkipDiscarded": true,
    "scrollThroughTabsExceptOverflow": true,
    "scrollThroughTabsCyclic": false,
    "scrollThroughTabsScrollArea": 0,
    "autoMenuMultiSel": true,
    "multipleMiddleClose": false,
    "longClickDelay": 500,
    "wheelThreshold": false,
    "wheelThresholdX": 10,
    "wheelThresholdY": 60,
    "tabDoubleClick": "none",
    "tabsSecondClickActPrev": true,
    "tabsSecondClickActPrevPanelOnly": false,
    "shiftSelAct": true,
    "activateOnMouseUp": false,
    "tabLongLeftClick": "none",
    "tabLongRightClick": "none",
    "tabMiddleClick": "close",
    "tabMiddleClickCtrl": "discard",
    "tabMiddleClickShift": "duplicate",
    "tabCloseMiddleClick": "close",
    "tabsPanelLeftClickAction": "none",
    "tabsPanelDoubleClickAction": "tab",
    "tabsPanelRightClickAction": "menu",
    "tabsPanelMiddleClickAction": "tab",
    "newTabMiddleClickAction": "new_child",
    "bookmarksLeftClickAction": "open_in_act",
    "bookmarksLeftClickActivate": false,
    "bookmarksLeftClickPos": "default",
    "bookmarksMidClickAction": "open_in_new",
    "bookmarksMidClickActivate": false,
    "bookmarksMidClickRemove": false,
    "bookmarksMidClickPos": "default",
    "historyLeftClickAction": "open_in_act",
    "historyLeftClickActivate": false,
    "historyLeftClickPos": "default",
    "historyMidClickAction": "open_in_new",
    "historyMidClickActivate": false,
    "historyMidClickPos": "default",
    "syncName": "",
    "syncSaveSettings": false,
    "syncSaveCtxMenu": false,
    "syncSaveStyles": false,
    "syncSaveKeybindings": false,
    "selectActiveTabFirst": true
  },
  "permissions": {
    "allUrls": false,
    "webRequest": false,
    "webRequestBlocking": false,
    "proxy": false,
    "tabHide": false,
    "clipboardWrite": false,
    "history": false,
    "bookmarks": false,
    "downloads": false
  },
  "storage": {
    "size": "2.86 kb",
    "props": {
      "containers": "1.07 kb",
      "favDomains": "78 b",
      "favHashes": "11 b",
      "favicons_01": "738 b",
      "favicons_02": "2 b",
      "favicons_03": "2 b",
      "favicons_04": "2 b",
      "favicons_05": "2 b",
      "profileID": "14 b",
      "sidebar": "386 b",
      "tabsDataCache": "424 b",
      "ver": "7 b"
    }
  },
  "sidebar": {
    "panels": {
      "l4loC_3_nKnc": {
        "type": 2,
        "id": "l4loC_3_nKnc",
        "name": "len: 4",
        "color": "toolbar",
        "iconSVG": "icon_tabs",
        "iconIMGSrc": "",
        "iconIMG": "",
        "lockedPanel": false,
        "skipOnSwitching": false,
        "noEmpty": false,
        "newTabCtx": "none",
        "dropTabCtx": "none",
        "moveRules": [],
        "moveExcludedTo": -1,
        "bookmarksFolderId": -1,
        "newTabBtns": [],
        "srcPanelConfig": null
      }
    },
    "nav": [
      "l4loC_3_nKnc",
      "add_tp",
      "sp-0",
      "settings"
    ]
  },
  "containers": [
    {
      "id": "firefox-container-1",
      "cookieStoreId": "firefox-container-1",
      "name": "8",
      "icon": "...",
      "color": "blue",
      "colorCode": "#37adff",
      "proxified": false,
      "proxy": null,
      "reopenRulesActive": false,
      "reopenRules": [],
      "userAgentActive": false,
      "userAgent": ""
    },
    {
      "id": "firefox-container-2",
      "cookieStoreId": "firefox-container-2",
      "name": "4",
      "icon": "...",
      "color": "orange",
      "colorCode": "#37adff",
      "proxified": false,
      "proxy": null,
      "reopenRulesActive": false,
      "reopenRules": [],
      "userAgentActive": false,
      "userAgent": ""
    },
    {
      "id": "firefox-container-3",
      "cookieStoreId": "firefox-container-3",
      "name": "7",
      "icon": "...",
      "color": "green",
      "colorCode": "#37adff",
      "proxified": false,
      "proxy": null,
      "reopenRulesActive": false,
      "reopenRules": [],
      "userAgentActive": false,
      "userAgent": ""
    },
    {
      "id": "firefox-container-4",
      "cookieStoreId": "firefox-container-4",
      "name": "8",
      "icon": "...",
      "color": "pink",
      "colorCode": "#37adff",
      "proxified": false,
      "proxy": null,
      "reopenRulesActive": false,
      "reopenRules": [],
      "userAgentActive": false,
      "userAgent": ""
    }
  ],
  "windows": [
    {
      "state": "maximized",
      "incognito": false,
      "tabsCount": 3
    },
    {
      "state": "maximized",
      "incognito": false,
      "tabsCount": 1
    }
  ],
  "bookmarks": "TypeError: browser.bookmarks is undefined"
}
Logs No logs show up when pressing F1 in a window where it doesn't work. This shows up when toggling sidebery off and on, but I don't think it shows anything wrong: ``` [bg] Init start chunk-4CCDWPNC.js:2:7771 [bg] Init end: 39ms chunk-4CCDWPNC.js:2:7771 [sidebar] Init start 2 chunk-4CCDWPNC.js:2:7771 [sidebar:1] Sidebar.loadPanels chunk-4CCDWPNC.js:2:7771 [sidebar:1] Sidebar.loadPanels: Done: 2ms chunk-4CCDWPNC.js:2:7771 [sidebar:1] Tabs.load chunk-4CCDWPNC.js:2:7771 [sidebar:1] Tabs.restoreTabsState chunk-4CCDWPNC.js:2:7771 [bg] IPC.onConnected sidebar 1 chunk-4CCDWPNC.js:2:7771 [sidebar:152] Sidebar.loadPanels chunk-4CCDWPNC.js:2:7771 [bg] Windows.isWindowTabsLocked 1 chunk-4CCDWPNC.js:2:7771 [sidebar:152] Sidebar.loadPanels: Done: 3ms chunk-4CCDWPNC.js:2:7771 [sidebar:152] Tabs.load chunk-4CCDWPNC.js:2:7771 [sidebar:152] Tabs.restoreTabsState chunk-4CCDWPNC.js:2:7771 [sidebar:1] Tabs.restoreTabsFromCache chunk-4CCDWPNC.js:2:7771 [sidebar:1] Tabs.restoreTabsState: Done: 17ms chunk-4CCDWPNC.js:2:7771 [sidebar:1] Tabs.load: Done: 19ms chunk-4CCDWPNC.js:2:7771 [sidebar:1] Init end: 45ms chunk-4CCDWPNC.js:2:7771 [bg] IPC.onConnected sidebar 152 chunk-4CCDWPNC.js:2:7771 [bg] Windows.isWindowTabsLocked 152 chunk-4CCDWPNC.js:2:7771 [sidebar:152] Tabs.restoreTabsFromCache chunk-4CCDWPNC.js:2:7771 [sidebar:152] Tabs.restoreTabsState: Done: 16ms chunk-4CCDWPNC.js:2:7771 [sidebar:152] Tabs.load: Done: 19ms chunk-4CCDWPNC.js:2:7771 [sidebar:152] Init end: 52ms chunk-4CCDWPNC.js:2:7771 ```
@mbnuqw
Copy link
Owner

mbnuqw commented Mar 4, 2024

Resolved in 403f33d

@mbnuqw mbnuqw closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants