Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper support for non-QWERTY layouts in keybindings #476

Closed
andrhua opened this issue Sep 23, 2021 · 2 comments
Closed

Add proper support for non-QWERTY layouts in keybindings #476

andrhua opened this issue Sep 23, 2021 · 2 comments
Labels
reproduced: yes type: bug

Comments

@andrhua
Copy link

andrhua commented Sep 23, 2021

Description

image
When setting Ctrl + S on Colemak, extension registers it as Ctrl + D, and then when using this shortcut I should press Ctrl + D on Colemak, which is Ctrl + G on QWERTY.

I think using key instead of code here should do the trick.
mbnuqw added a commit that referenced this issue May 19, 2022
@mbnuqw
Fixed: Keybindings: Use a key character to generate shortcut
72c1ef3 
(#476)
@Fred-Vatin
Copy link

Fred-Vatin commented Jul 6, 2022 •
edited

v4.10
Yes I use AZERTY and the problem is it detects the right keybinding but always display the as it is in a QWERTY.

As a workaround, invite the user to use the config:addons>shortcuts

@mbnuqw
Copy link
Owner

mbnuqw commented Mar 5, 2024 •
edited

Fixed from v5.0.0

@mbnuqw mbnuqw closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reproduced: yes type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbnuqw @andrhua @Fred-Vatin