Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs duplicated from sidebar placed incorrectly #728

Closed
fidgetkeys opened this issue Aug 25, 2022 · 1 comment
Closed

tabs duplicated from sidebar placed incorrectly #728

fidgetkeys opened this issue Aug 25, 2022 · 1 comment

Comments

@fidgetkeys
Copy link

Steps to reproduce

create tab tree with at least one child
collapse tree
right click on the tab in the sidebery panel
select "duplicate tabs"

Expected behavior

tab will be duplicated with all children

Actual behavior

tab is duplicated as a sibling tab, but child tabs are placed as child of the original tab, as siblings of their duplicates

Debug info

Addon data

{
"settings": {
"version": "4.10.1",
"nativeScrollbars": false,
"selWinScreenshots": true,
"tabsCheck": true,
"tabsFix": "notify",
"markWindow": false,
"markWindowPreface": "[Sidebery] ",
"ctxMenuNative": true,
"autoHideCtxMenu": "none",
"ctxMenuRenderInact": true,
"ctxMenuIgnoreContainers": "",
"navBarLayout": "horizontal",
"navBarInline": false,
"hideAddBtn": false,
"hideSettingsBtn": false,
"navBtnCount": true,
"hideEmptyPanels": true,
"navActTabsPanelLeftClickAction": "none",
"navActBookmarksPanelLeftClickAction": "none",
"navMidClickAction": "rm_all",
"navSwitchPanelsWheel": true,
"groupLayout": "grid",
"skipEmptyPanels": false,
"dndTabAct": false,
"dndTabActDelay": 750,
"dndTabActMod": "none",
"dndExp": "pointer",
"dndExpDelay": 0,
"dndExpMod": "none",
"stateStorage": "session",
"warnOnMultiTabClose": "any",
"activateOnMouseUp": true,
"activateLastTabOnPanelSwitching": true,
"showTabRmBtn": true,
"showTabCtx": true,
"hideInact": true,
"activateAfterClosing": "next",
"activateAfterClosingPrevRule": "visible",
"activateAfterClosingNextRule": "tree",
"activateAfterClosingGlobal": false,
"activateAfterClosingNoFolded": true,
"activateAfterClosingNoDiscarded": true,
"shiftSelAct": true,
"askNewBookmarkPlace": true,
"tabsRmUndoNote": true,
"nativeHighlight": false,
"tabsUnreadMark": false,
"tabsReloadLimit": 5,
"tabsReloadLimitNotif": true,
"tabsPanelSwitchActMove": true,
"moveNewTabPin": "end",
"moveNewTabParent": "last_child",
"moveNewTabParentActPanel": false,
"moveNewTab": "end",
"pinnedTabsPosition": "panel",
"pinnedTabsList": false,
"pinnedAutoGroup": true,
"tabsTree": true,
"groupOnOpen": true,
"tabsTreeLimit": "none",
"hideFoldedTabs": true,
"autoFoldTabs": false,
"autoFoldTabsExcept": "none",
"autoExpandTabs": false,
"rmChildTabs": "all",
"tabsChildCount": true,
"tabsLvlDots": true,
"discardFolded": false,
"discardFoldedDelay": 0,
"discardFoldedDelayUnit": "sec",
"tabsTreeBookmarks": true,
"treeRmOutdent": "first_child",
"bookmarksPanel": true,
"warnOnMultiBookmarkDelete": "collapsed",
"openBookmarkNewTab": true,
"midClickBookmark": "delete",
"actMidClickTab": true,
"autoCloseBookmarks": false,
"autoRemoveOther": true,
"highlightOpenBookmarks": false,
"activateOpenBookmarkTab": true,
"showBookmarkLen": true,
"bookmarksRmUndoNote": true,
"fontSize": "s",
"bgNoise": true,
"animations": true,
"animationSpeed": "fast",
"theme": "default",
"style": "dark",
"sidebarCSS": false,
"groupCSS": false,
"snapNotify": true,
"snapExcludePrivate": false,
"snapInterval": 0,
"snapIntervalUnit": "min",
"snapLimit": 0,
"snapLimitUnit": "snap",
"hScrollThroughPanels": false,
"scrollThroughTabs": "panel",
"scrollThroughVisibleTabs": true,
"scrollThroughTabsSkipDiscarded": false,
"scrollThroughTabsExceptOverflow": false,
"scrollThroughTabsCyclic": true,
"tabDoubleClick": "none",
"tabLongLeftClick": "new_child",
"tabLongRightClick": "new_after",
"tabsPanelLeftClickAction": "expand",
"tabsPanelDoubleClickAction": "collapse",
"tabsPanelRightClickAction": "menu",
"tabsPanelMiddleClickAction": "tab",
"syncName": "",
"syncSaveSettings": false,
"syncSaveCtxMenu": false,
"syncSaveStyles": false,
"syncAutoApply": false
},
"permissions": {
"allUrls": true,
"tabHide": true,
"actualAllUrls": true,
"actualTabHide": true
},
"storage": {
"size": "1 mb",
"props": {
"bookmarksMenu": "226 b",
"bookmarksPanelMenu": "54 b",
"containers_v4": "1 kb",
"cssVars": "1.6 kb",
"disabledKeybindings": "2 b",
"expandedBookmarks": "67 b",
"favAutoCleanTime": "10 b",
"favUrls": "52.4 kb",
"favicons": "1002.1 kb",
"lastSnapTime": "13 b",
"panelIndex": "1 b",
"panels_v4": "854 b",
"prevTabsData_v4": "214 b",
"profileID": "14 b",
"settings": "2.8 kb",
"snapshots_v4": "4.2 kb",
"tabsData_v4": "8.8 kb",
"tabsMenu": "408 b",
"tabsPanelMenu": "184 b"
}
},
"panels": [
{
"type": "bookmarks",
"id": "bookmarks",
"cookieStoreId": "bookmarks",
"name": 9,
"icon": "...",
"bookmarks": true,
"lockedPanel": false,
"skipOnSwitching": false
},
{
"type": "default",
"id": "firefox-default",
"name": 7,
"icon": "...",
"cookieStoreId": "firefox-default",
"lockedTabs": false,
"lockedPanel": false,
"skipOnSwitching": false,
"noEmpty": false,
"newTabCtx": "firefox-default",
"dropTabCtx": "firefox-default",
"moveTabCtx": "firefox-default",
"moveTabCtxNoChild": false
},
{
"type": "tabs",
"id": "LtS6E3IKwa3s",
"name": 11,
"icon": "...",
"color": "...",
"customIconSrc": "",
"customIcon": "",
"lockedTabs": false,
"lockedPanel": false,
"skipOnSwitching": false,
"noEmpty": false,
"newTabCtx": "firefox-container-2",
"dropTabCtx": "firefox-container-2",
"moveTabCtx": "firefox-container-2",
"moveTabCtxNoChild": false,
"urlRulesActive": false,
"urlRules": ""
}
],
"containers": [
{
"id": "firefox-container-1",
"name": 8,
"icon": "...",
"color": "...",
"proxified": false,
"proxy": null,
"includeHostsActive": false,
"includeHosts": "",
"excludeHostsActive": false,
"excludeHosts": "",
"userAgentActive": false,
"userAgent": ""
},
{
"id": "firefox-container-2",
"name": 6,
"icon": "...",
"color": "...",
"proxified": false,
"proxy": null,
"includeHostsActive": false,
"includeHosts": "",
"excludeHostsActive": false,
"excludeHosts": "",
"userAgentActive": false,
"userAgent": ""
},
{
"id": "firefox-container-3",
"name": 7,
"icon": "...",
"color": "...",
"proxified": false,
"proxy": null,
"includeHostsActive": false,
"includeHosts": "",
"excludeHostsActive": false,
"excludeHosts": "",
"userAgentActive": false,
"userAgent": ""
},
{
"id": "firefox-container-4",
"name": 8,
"icon": "...",
"color": "...",
"proxified": false,
"proxy": null,
"includeHostsActive": false,
"includeHosts": "",
"excludeHostsActive": false,
"excludeHosts": "",
"userAgentActive": false,
"userAgent": ""
}
],
"cssVars": {},
"windows": [
{
"state": "maximized",
"incognito": false,
"tabsCount": 15
},
{
"state": "maximized",
"incognito": false,
"tabsCount": 1
}
],
"tabsMenu": [
[
"undoRmTab",
"mute",
"reload",
"bookmark"
],
"separator-1",
[
{
"name": "Move to"
},
"moveToNewWin",
"moveToWin",
"moveToPanel"
],
[
{
"name": "Reopen in"
},
"reopenInNewWin",
"reopenInWin",
"reopenInCtr"
],
"separator-2",
"pin",
"duplicate",
"discard",
"copyUrls",
"separator-3",
"group",
"flatten",
"separator-4",
"clearCookies",
"separator-31162839691810973",
"close",
"closeDescendants",
"closeTabsAbove",
"closeTabsBelow",
"closeOtherTabs"
],
"bookmarksMenu": [
[
{
"name": "Open in"
},
"openInNewWin",
"openInNewPrivWin",
"openInCtr"
],
"separator-5",
"createBookmark",
"createFolder",
"createSeparator",
"separator-6",
"sortByName",
"sortByLink",
"sortByTime",
"separator-7",
"copyUrls",
"edit",
"delete"
],
"bookmarks": {
"bookmarksCount": 206,
"foldersCount": 53,
"separatorsCount": 0,
"maxDepth": 5
}
}

Logs

@mbnuqw
Copy link
Owner

mbnuqw commented Mar 8, 2024

Fixed from v5.0.0

@mbnuqw mbnuqw closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants