Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent incorrect drag drop node highlighting #752

Merged
merged 3 commits into from
Sep 24, 2023

Conversation

mbraak
Copy link
Owner

@mbraak mbraak commented Sep 23, 2023

Fix for #734

@github-actions
Copy link

github-actions bot commented Sep 23, 2023

Size Change: +129 B (0%)

Total Size: 42.7 kB

Filename Size Change
./lib/dragAndDropHandler.js 5.69 kB +129 B (+2%)
ℹ️ View Unchanged
Filename Size
./lib/dataLoader.js 1.8 kB
./lib/elementsRenderer.js 3.13 kB
./lib/jqtreeOptions.js 33 B
./lib/keyHandler.js 1.54 kB
./lib/mouse.widget.js 2.67 kB
./lib/node.js 5.31 kB
./lib/nodeElement.js 3.03 kB
./lib/saveStateHandler.js 3.04 kB
./lib/scrollHandler.js 3 kB
./lib/selectNodeHandler.js 1.51 kB
./lib/simple.widget.js 2.58 kB
./lib/tree.jquery.js 8.98 kB
./lib/types.js 33 B
./lib/util.js 247 B
./lib/version.js 149 B

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.21% ⚠️

Comparison is base (b430718) 87.40% compared to head (ede9d18) 87.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #752      +/-   ##
==========================================
- Coverage   87.40%   87.20%   -0.21%     
==========================================
  Files          18       18              
  Lines        2175     2180       +5     
  Branches      629      631       +2     
==========================================
  Hits         1901     1901              
- Misses        274      279       +5     
Files Changed Coverage Δ
src/dragAndDropHandler.ts 83.64% <16.66%> (-1.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbraak mbraak merged commit 89aca7d into dev Sep 24, 2023
4 of 6 checks passed
@mbraak mbraak deleted the fix-inconsistent-incorrect-drag-drop-node-highlighting branch September 24, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant